Skip to content

Add support for Python 3.12, 3.13, and 3.14 in setup.py#66

Merged
Borda merged 1 commit into
Borda:mainfrom
onuralpszr:chore/python-classifiers
Nov 9, 2025
Merged

Add support for Python 3.12, 3.13, and 3.14 in setup.py#66
Borda merged 1 commit into
Borda:mainfrom
onuralpszr:chore/python-classifiers

Conversation

@onuralpszr

Copy link
Copy Markdown
Contributor

I also added tox test to be sure all versions are fine.

  py38: OK (9.06=setup[7.38]+cmd[1.68] seconds)
  py39: OK (14.89=setup[12.94]+cmd[1.95] seconds)
  py310: OK (7.60=setup[5.70]+cmd[1.90] seconds)
  py311: OK (9.45=setup[7.52]+cmd[1.94] seconds)
  py312: OK (6.32=setup[4.22]+cmd[2.10] seconds)
  py313: OK (9.91=setup[7.68]+cmd[2.23] seconds)
  py314: OK (10.83=setup[8.42]+cmd[2.41] seconds)
  congratulations :) (68.09 seconds)

@onuralpszr onuralpszr requested a review from Borda as a code owner November 9, 2025 15:11
@codecov

codecov Bot commented Nov 9, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (10d5862) to head (71c0ecf).
⚠️ Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #66   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          134       134           
=========================================
  Hits           134       134           
Flag Coverage Δ
pytest 100.00% <ø> (ø)
python3.11 ?
python3.12 100.00% <ø> (?)
python3.7 ?
python3.9 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Borda Borda left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the tox is needed?

@onuralpszr

Copy link
Copy Markdown
Contributor Author

Why the tox is needed ?

For locally test all python versions, not mandatory I can removed but I used for testing all version to be sure. Old and new ones.

@onuralpszr onuralpszr force-pushed the chore/python-classifiers branch from 02c1372 to c74a4b7 Compare November 9, 2025 15:16
@onuralpszr onuralpszr requested a review from Borda November 9, 2025 15:17
@Borda

Borda commented Nov 9, 2025

Copy link
Copy Markdown
Owner

Why the tox is needed ?

For locally test all python versions, not mandatory I can removed but I used for testing all version to be sure. Old and new ones.

Sounds good, let's add add it as another PR and include instruction how to use it please...

@onuralpszr onuralpszr force-pushed the chore/python-classifiers branch from c74a4b7 to 0ccc15d Compare November 9, 2025 17:37
@onuralpszr onuralpszr changed the title Add support for Python 3.12, 3.13, and 3.14 in setup.py; create tox.ini for testing environment Add support for Python 3.12, 3.13, and 3.14 in setup.py Nov 9, 2025
Signed-off-by: Onuralp SEZER <onuralp@ultralytics.com>
@onuralpszr onuralpszr force-pushed the chore/python-classifiers branch from 0ccc15d to 71c0ecf Compare November 9, 2025 17:38
@onuralpszr

Copy link
Copy Markdown
Contributor Author

Why the tox is needed ?

For locally test all python versions, not mandatory I can removed but I used for testing all version to be sure. Old and new ones.

Sounds good, let's add add it as another PR and include instruction how to use it please...

It is done, we can merge it.

@Borda Borda enabled auto-merge (squash) November 9, 2025 17:54
@Borda Borda merged commit 99bfe1c into Borda:main Nov 9, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants