odata startswith uri differs from odata standard and causes entity framework to generate suboptimal sql

[jgtestw]

The code that converts a startswith predicate to an odata uri generates the following uri

startswith(mobile,'0430404111') eq true

instead of

startswith(mobile,'0430404111')

This causes the sql generated by entity framework to be suboptimal. Why do you tack eq true onto the end of the startswith? The odata standard does not require this. It also makes entity framework generate suboptimal sql:

((CASE WHEN ([Extent1].[Mobile] LIKE @p__linq__0 ESCAPE N''~'') THEN cast(1 as bit) WHEN ( NOT ([Extent1].[Mobile] LIKE @p__linq__0 ESCAPE N''~'')) THEN cast(0 as bit) END) = @p__linq__1)

instead of

[Extent1].[Mobile] LIKE @p__linq__0 ESCAPE N''~''

[steveschmitt]

I don't know the answer why Breeze does that, but it may be that Entity Framework didn't work the same way back when Breeze was first tested. Frankly, I'm surprised that EF handles eq true so poorly. What version of EF are you using?

[jgtestw]

EF 6

[jgtestw]

@steveschmitt Can you foresee any problem with changing the code in our custom odata uri adapter to not add the eq true part to the end of startswith?

[steveschmitt]

@jgtestw It is fine for you to change the code.

[jgtestw]

@steveschmitt Ok thanks

[jgtestw]

@steveschmitt Do you want me to update the actual breeze source code too? Submit a pull request?

[steveschmitt]

Yes, please submit a pull request.

[jgtestw]

ok i will