Increase php-parser use#278
Open
BrianHenryIE wants to merge 635 commits into
Open
Conversation
|
Generated: Sat, Jun 27, 2026, 0:48:06 UTC.
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the symbol discovery and replacement logic, moving from a regex-based implementation to an AST-based approach using the PHP-Parser library. It introduces a DiscoveredSymbols collection to manage various symbol types and updates the Prefixer to handle global symbols, namespace aliasing, and PHPDoc replacements. The review feedback highlights several critical areas for improvement: the regex for string-based classname replacement is too restrictive and incorrectly uses preg_quote, the AST walker may process comments multiple times leading to invalid offsets, and the circular dependency workaround in the File class is fragile. Additionally, the heuristic for closing braces in partial snippets is unreliable, and some log messages need updating to reflect the new architecture.
maybe it should be optional/configurable
This was referenced Jun 24, 2026
Not sure how best to deal with them though.
Actual array: ['GLOBAL_CONST']. Failed asserting that an array contains 'MYPREFIX_GLOBAL_CONST'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should eliminate some bugs.
Also includes:
SymlinkProtectFilesystemAdapter#170 Add and extractSymlinkFileSystempackage #151TODO:
Prefixer.php