upgrade golang.org/x/tools to latest version #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kujenga
commented
Oct 20, 2022
| @@ -1,6 +1,15 @@ | |||
| module github.com/BurntSushi/go-sumtype | |||
|
|
|||
| go 1.17 | |||
There was a problem hiding this comment.
This was set to an older Go version as it seemed unnecessary to pull it all the way up to Go 1.19, and the new behavior of Go 1.19 is to add this line as go 1.19 if it's unspecified. If you have opinions on setting it to something else, happy to update accordingly.
There was a problem hiding this comment.
I think 1.17 is "old enough" :-)
This commit resolves an issue where on Go 1.19, errors of the following
form appear, when an internal package "xyz" would import from the
standard library.
internal error: package "fmt" without types was imported from "xyz"
This problem was discussed in the Go issue tracker here as well:
golang/go#37617
Closes BurntSushi#17
kujenga
force-pushed
the
at/pkg-upgrade
branch
from
fa8d7e8 to
61cf569
Compare
BurntSushi
approved these changes
Oct 20, 2022
| @@ -1,6 +1,15 @@ | |||
| module github.com/BurntSushi/go-sumtype | |||
|
|
|||
| go 1.17 | |||
There was a problem hiding this comment.
I think 1.17 is "old enough" :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit resolves an issue where on Go 1.19, errors of the following form appear, when an internal package "xyz" would import from the standard library.
This problem was discussed in the Go issue tracker here as well: golang/go#37617
Closes #17