Skip to content

revert(renovate): drop "uv" from enabledManagers (#149) - #151

Merged
williaby merged 1 commit into
mainfrom
claude/revert-renovate-uv-manager-149
May 25, 2026
Merged

williaby merged 1 commit into
mainfrom
claude/revert-renovate-uv-manager-149

Conversation

@williaby

@williaby williaby commented May 24, 2026 •

Copy link
Copy Markdown
Collaborator

Reverts: #149

Summary

Reverts #149, which added "uv" to enabledManagers in renovate.json. The added entry caused Renovate to reject the entire org-default config with a validation error on every downstream run.

What broke

Renovate (v42.92.14) does not ship a manager named uv. The homelab team verified this by inspecting the manager directory inside the running Renovate container. With "uv" in enabledManagers, Renovate emits:

Config validation errors found: The following managers configured in enabledManagers are not supported: "uv"

This rejects the entire config, not just the offending line. Every downstream repo that inherits ByronWilliamsCPA/.github:renovate.json (homelab-infra, gleif, backpacking, williaby-claude, .claude, image-generation, reference-library, plus future repos) stopped getting Renovate updates after #149 merged.

How uv projects are actually covered

PR #149 was based on a wrong mental model. uv support in Renovate works as follows:

  1. Dependency detection: uv uses the standard PEP 621 [project] table in pyproject.toml. The existing pep621 manager (already in enabledManagers) finds these dependencies. No separate uv manager is needed.
  2. Lockfile regeneration: uv.lock is regenerated as a PR artifact by the Renovate container. This is handled in homelab-infra/services/renovate/docker-compose.yml via RENOVATE_BINARY_SOURCE=install, which lets containerbase download the uv binary at runtime. Configured in homelab-infra PR chore(deps): Update GitHub Actions #309 (merged), follow-up cleanup in PR #314.

The absence of "uv" from enabledManagers is therefore deliberate, not an oversight.

Why this trap is sticky

"uv" is intuitively the right manager name for a uv-lockfile-managed project. Two independent agents have now reached for it (the homelab team in May, and the author of #149). Without a tombstone, the next contributor will reach for it again.

This PR captures the tombstone in the PR body and in the maintainer's session memory (so future Claude Code sessions on this repo will not re-suggest the same fix). A future contributor who proposes adding "uv" to enabledManagers should be referred to this PR.

Pre-merge audit suggestion

The lookup that would have prevented #149:

gh pr list --repo ByronWilliamsCPA/homelab-infra --search "renovate enabledManagers uv" --state all
git -C ~/dev/homelab-infra log --all -S '"uv"' -- services/renovate/config/config.json

Either would have surfaced PR #309 and #314 within seconds, exposing the deliberate-revert reasoning that lived in the consumer repo rather than the source repo.

Change

   "enabledManagers": [
-    "uv",
     "pep621",
     "pip_requirements",
     "github-actions"
   ],

One-line removal. Restores the pre-#149 config.

Test plan

  • Pre-commit hooks pass locally (pre-commit run --all-files)
  • CI passes on this PR
  • After merge, observe Renovate runs on downstream repos succeed (no validation error)
  • Confirm pep621-managed uv deps continue to receive update PRs

Generated with Claude Code

Copilot AI review requested due to automatic review settings May 24, 2026 23:36
@coderabbitai

coderabbitai Bot commented May 24, 2026 •

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

This PR removes the uv package manager from Renovate's enabledManagers configuration. The array now explicitly enables pep621, pip_requirements, and github-actions managers.

Changes

Dependency Management Configuration

Layer / File(s) Summary
Remove uv manager from enabledManagers
renovate.json
The 'uv' manager entry was removed from the enabledManagers array, which now contains pep621, pip_requirements, and github-actions.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A single line removed with care,
Uv manager no longer there,
Configuration clean and bright,
The dependencies now right! 🐰✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the change as reverting the addition of 'uv' from enabledManagers in renovate.json, directly matching the primary modification in the changeset.
Description check ✅ Passed The PR description is comprehensive and well-structured, covering the issue context, root cause analysis, explanation of why 'uv' is not needed, and detailed testing/audit guidance—though it deviates from the repository's template structure.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/revert-renovate-uv-manager-149

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud

Copy link
Copy Markdown

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts the Renovate org-default config change from #149 by removing the unsupported uv entry from enabledManagers, restoring downstream Renovate validation.

Changes:

  • Removes "uv" from renovate.json.
  • Keeps existing supported managers for PEP 621, pip requirements, and GitHub Actions.

Comment thread renovate.json
@@ -77,7 +77,6 @@
}
],
"enabledManagers": [
@williaby

Copy link
Copy Markdown
Collaborator Author

PR Review

Status: BUILD FAILING (3 CI checks) — single root cause. Quality of the change itself is good.

Critical (must fix before merge)

  1. CI / PR Title Format — FAILED. The title Revert "chore(renovate): add uv to org-default enabledManagers" (#149) does not match the conventional-commits regex ^(feat|fix|...|revert)(\([^()]+\))?!?: .+, which requires a lowercase type prefix followed by :. Git's default Revert "..." format is incompatible. Job log

    Fix: rename PR to e.g. revert(renovate): drop "uv" from enabledManagers (#149).

  2. CI / PR Validation Gate — FAILURE. Cascading from feat: update organization files to align with current best practices #1; will turn green automatically.

  3. CI / Dependency & Standards Validation — FAILURE. Cascading from feat: update organization files to align with current best practices #1; will turn green automatically.

Other reviewer signals

  • Copilot: independently flagged the title issue (1 inline comment).
  • CodeRabbit: no actionable comments.
  • SonarQube: Quality Gate passed; 0 issues, 0 hotspots.

The change itself

The one-line removal of "uv" from renovate.json is correct and well-justified. Renovate has no uv manager; pep621 already covers uv-managed pyproject.toml, and the binary is supplied via RENOVATE_BINARY_SOURCE=install in the homelab Renovate container. The PR body's tombstone and pre-merge audit queries are excellent prevention against re-introduction.

🤖 Generated with Claude Code

@williaby williaby changed the title Revert "chore(renovate): add uv to org-default enabledManagers" (#149) revert(renovate): drop "uv" from enabledManagers (#149) May 24, 2026
@williaby
williaby merged commit 62bfd79 into main May 25, 2026
25 of 31 checks passed
@williaby
williaby deleted the claude/revert-renovate-uv-manager-149 branch May 25, 2026 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants