Skip to content

fix(ci): use exact filename for upload-artifact path - #30

Merged
williaby merged 1 commit into
mainfrom
fix/sbom-exact-filename
Apr 10, 2026
Merged

williaby merged 1 commit into
mainfrom
fix/sbom-exact-filename

Conversation

@williaby

Copy link
Copy Markdown
Collaborator

Summary

Replaces the glob pattern sbom-*.json with the exact filename sbom-runtime.json. The glob triggers a known bug in upload-artifact@v4's resolver when the workspace path contains repeated directory segments — here, the repo is named .claude, so GitHub sets GITHUB_WORKSPACE to /home/runner/work/.claude/.claude/, and the repeated component causes the glob to fail even when the file exists.

Since the generate step produces exactly one file, no glob is needed. Using the exact filename bypasses the resolver bug entirely. The ${{ github.workspace }} prefix is retained to avoid the separate CWD ≠ GITHUB_WORKSPACE failure in reusable workflows.

What has been tried and ruled out

PR Upload path Outcome
#25 sbom-*.json (relative glob) file not created — generation was broken
#26 ${{ github.workspace }}/sbom-*.json file created; glob resolver bug triggered
#27 ${{ github.workspace }}/sbom-*.json with v4.5.0 merged; same bug
#28 sbom-*.json (relative, no prefix) CWD ≠ GITHUB_WORKSPACE in reusable workflow
#29 ${{ github.workspace }}/sbom-*.json same glob resolver bug
#30 ${{ github.workspace }}/sbom-runtime.json (exact filename) this PR

Note on action version SHAs

The previous PR description supplied two incorrect SHAs (ff15f030 = v3.2.1; 95815c38 = untagged commit). No action version changes in this PR. A follow-up to upgrade upload-artifact from v4.5.0 to the current v7.x line can land after the functional bug is confirmed fixed.

Testing

  • Trigger the SBOM workflow and confirm the upload step succeeds
  • Confirm scan-runtime and license-compliance jobs receive the artifact

🤖 Generated with Claude Code

The glob pattern sbom-*.json (and its absolute variants) triggers a
known bug in upload-artifact@v4's glob resolver when the workspace
path contains repeated directory segments (here: .claude/.claude —
the repo is named .claude, so GitHub sets GITHUB_WORKSPACE to
/home/runner/work/.claude/.claude).

Since the generate step produces exactly one file, sbom-runtime.json,
no glob is needed. Using the exact filename bypasses the glob resolver
entirely. The path retains the ${{ github.workspace }} prefix to avoid
the separate CWD != GITHUB_WORKSPACE issue in reusable workflows.

Note: the SHAs supplied in the previous PR description were incorrect
(ff15f030 = v3.2.1, not v4.6.2; 95815c38 has no release tag). No
action version changes in this commit — that can be a follow-up once
the functional bug is confirmed fixed.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Apr 10, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@williaby has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 9 minutes and 53 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 9 minutes and 53 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9f58ca18-160a-4af4-a3f2-7f678a50c625

📥 Commits

Reviewing files that changed from the base of the PR and between 24e46da and 42a8eff.

📒 Files selected for processing (1)
  • .github/workflows/python-sbom.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/sbom-exact-filename

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@williaby
williaby merged commit 079df49 into main Apr 10, 2026
4 checks passed
@williaby
williaby deleted the fix/sbom-exact-filename branch April 18, 2026 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant