Skip to content

fix(supply-chain): pass DHI pull creds to promote-core; re-pin caller - #31

Merged
williaby merged 1 commit into
mainfrom
fix/mirror-caller-upstream-auth
Jun 30, 2026
Merged

williaby merged 1 commit into
mainfrom
fix/mirror-caller-upstream-auth

Conversation

@williaby

Copy link
Copy Markdown
Contributor

Summary

Follow-up to the dhi-postgres-17 bake run, which failed in promote-core's scan job with 401 Unauthorized from dhi.io. The scan job pulls the candidate bytes (mirror-verify only resolves the digest) and had no upstream credentials.

.github #237 (merged) added optional UPSTREAM_REGISTRY_USERNAME/UPSTREAM_REGISTRY_TOKEN secrets to promote-core. This PR:

  • Passes the repo's DHI_REGISTRY_USERNAME/DHI_REGISTRY_TOKEN through to those secrets.
  • Re-pins both uses: (mirror-verify + promote-core) to .github@5825ec5, the commit carrying the auth fix.

Validation

yaml.safe_load clean; actionlint clean; both SHA pins confirmed updated (old SHA absent); pre-commit passes.

After merge

Re-run "Supply Chain Mirror (bake)". The scan job should now authenticate to dhi.io and proceed into Grype/Snyk; the run advances to the next stage (publish/sign/lock), surfacing any further issues per the bake loop.

Generated with Claude Code

…thub@5825ec5

The dhi-postgres-17 bake run failed in promote-core's scan job with a 401 from
dhi.io: the scan job pulls the bytes (mirror-verify only resolves the digest)
and had no upstream credentials. .github #237 added optional
UPSTREAM_REGISTRY_USERNAME/TOKEN secrets to promote-core; pass the DHI creds
through and re-pin both reusable-workflow refs to the SHA that carries the fix.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@williaby, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 12 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9566757a-8991-4760-8534-7ab647d68600

📥 Commits

Reviewing files that changed from the base of the PR and between d36e11d and 8d5e302.

📒 Files selected for processing (1)
  • .github/workflows/supply-chain-mirror.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/mirror-caller-upstream-auth

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

Dependency Review

The following issues were found:
  • ✅ 0 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ⚠️ 2 package(s) with unknown licenses.
See the Details below.

License Issues

.github/workflows/supply-chain-mirror.yml

PackageVersionLicenseIssue Type
ByronWilliamsCPA/.github/.github/workflows/supply-chain-mirror-verify.yml5825ec597cb87f66efcc471f7f2d9fd47e5dcf14NullUnknown License
ByronWilliamsCPA/.github/.github/workflows/supply-chain-promote-core.yml5825ec597cb87f66efcc471f7f2d9fd47e5dcf14NullUnknown License

OpenSSF Scorecard

PackageVersionScoreDetails
actions/ByronWilliamsCPA/.github/.github/workflows/supply-chain-mirror-verify.yml 5825ec597cb87f66efcc471f7f2d9fd47e5dcf14 UnknownUnknown
actions/ByronWilliamsCPA/.github/.github/workflows/supply-chain-promote-core.yml 5825ec597cb87f66efcc471f7f2d9fd47e5dcf14 UnknownUnknown

Scanned Files

  • .github/workflows/supply-chain-mirror.yml

@sonarqubecloud

Copy link
Copy Markdown

@williaby

Copy link
Copy Markdown
Contributor Author

PR Review

PREMISE: OK — minimal, correctly-scoped forward fix. No Critical or Important findings; safe to merge.

Verification (all PR-body claims confirmed):

  • Ref 5825ec5 is the merge of org .github PR #237 (the auth fix) and is the current tip of .github main (compare main...5825ec5 = identical) — reachable and durable, not an orphaned PR SHA.
  • Callee supply-chain-promote-core.yml@5825ec5 declares both UPSTREAM_REGISTRY_USERNAME and UPSTREAM_REGISTRY_TOKEN as workflow_call secrets and consumes them in the scan job — the passed secret names match the interface (no load-time error).
  • Repo secrets DHI_REGISTRY_USERNAME/DHI_REGISTRY_TOKEN already exist (used by the verify job).
  • Old pin bec4d9f is fully absent from the file.
  • The verify job's SHA bump is behaviorally a no-op: bec4d9f...5825ec5 is one commit touching only promote-core.yml.

Suggested (non-blocking):

Note: CodeRabbit's check is green but its review was rate-limited (no substantive review ran); Copilot was not requested. This agent review is the substantive coverage.

🤖 Generated with Claude Code

@williaby
williaby added this pull request to the merge queue Jun 30, 2026
Merged via the queue into main with commit 71cb559 Jun 30, 2026
18 checks passed
@williaby
williaby deleted the fix/mirror-caller-upstream-auth branch June 30, 2026 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant