All recipes are being loaded

[stijnbernards]

https://github.com/ByteInternet/hypernode-deploy/blob/af8399448599403c381471f6a9a2992ece0d23ae/src/Deployer/RecipeLoader.php

We noticed here that all tasks are being loaded by default, which is not what you would want.

For example(deployer/deployer/recipe/provision/website.php):

Overrides the domain variable with a Deployer\ask and breaks the usage of get('domain')/set('domain') in build.

Loading all recipes at once also overrides a lot of other functions, creates duplicate variables etc.

If a Magento2 recipe is being used only that file should be required via PHP.

[tdgroot]

Hi @stijnbernards,

The recipe loader iterates over a (currently 1 element) list of directories where recipes might be located. It only includes a single file once it found one in the path, then returns.

We also have a similar loader (which indicates we can do some cleaning up) in the deploy configuration component. This loader loads from the configuration recipe path, but is more flexible because it also accepts an environment variable.

Anyways, they both load a single targeted file.

Does this answer your question? I'm curious how you got into a situation where recipe files were overriding eachother.