Skip to content

fix: fix global session timeout calculate#118

Merged
dk-lockdown merged 1 commit into
CECTC:devfrom
fatelei:fix-timeout
May 30, 2022
Merged

fix: fix global session timeout calculate#118
dk-lockdown merged 1 commit into
CECTC:devfrom
fatelei:fix-timeout

Conversation

@fatelei
Copy link
Copy Markdown
Collaborator

@fatelei fatelei commented May 30, 2022

ref: https://github.com/cectc/dbpack/issues/

Ⅰ. Describe what this PR did

fix global session queue add job with wrong delay at

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #118 (be813e3) into dev (9eff19f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #118   +/-   ##
=======================================
  Coverage   48.23%   48.23%           
=======================================
  Files          55       55           
  Lines        5759     5759           
=======================================
  Hits         2778     2778           
  Misses       2738     2738           
  Partials      243      243           
Impacted Files Coverage Δ
pkg/dt/undolog/table_records.pb.go 21.67% <ø> (ø)
pkg/dt/undolog/undo_log.pb.go 29.13% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9eff19f...be813e3. Read the comment docs.

@zhu733756
Copy link
Copy Markdown
Contributor

LGTM

1 similar comment
@zackzhangkai
Copy link
Copy Markdown
Contributor

LGTM

@dk-lockdown dk-lockdown merged commit bf3b084 into CECTC:dev May 30, 2022
@github-actions github-actions Bot locked and limited conversation to collaborators May 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants