Skip to content

feat: add status api#139

Merged
dk-lockdown merged 1 commit into
CECTC:devfrom
hzliangbin:dev
Jun 8, 2022
Merged

feat: add status api#139
dk-lockdown merged 1 commit into
CECTC:devfrom
hzliangbin:dev

Conversation

@hzliangbin
Copy link
Copy Markdown
Contributor

ref: https://github.com/cectc/dbpack/issues/

Ⅰ. Describe what this PR did

provide status api view dbpack listener and dt info

dbpack

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 8, 2022

Codecov Report

Merging #139 (59bb73c) into dev (056a303) will not change coverage.
The diff coverage is n/a.

❗ Current head 59bb73c differs from pull request most recent head b23d635. Consider uploading reports for the commit b23d635 to get more accurate results

@@           Coverage Diff           @@
##              dev     #139   +/-   ##
=======================================
  Coverage   49.42%   49.42%           
=======================================
  Files          62       62           
  Lines        6458     6458           
=======================================
  Hits         3192     3192           
  Misses       2970     2970           
  Partials      296      296           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 056a303...b23d635. Read the comment docs.

Copy link
Copy Markdown
Collaborator

@dk-lockdown dk-lockdown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread pkg/http/status.go Outdated
@adofsauron
Copy link
Copy Markdown

LGTM

@dk-lockdown dk-lockdown merged commit 93ceee0 into CECTC:dev Jun 8, 2022
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants