feat: add more trace span and integrate with jaeger#177
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #177 +/- ##
==========================================
- Coverage 43.05% 42.80% -0.25%
==========================================
Files 81 81
Lines 9483 9554 +71
==========================================
+ Hits 4083 4090 +7
- Misses 4994 5058 +64
Partials 406 406
Continue to review full report at Codecov.
|
Collaborator
|
To trace the entire lifecycle of a transaction, should start with the http request proxy:
|
97ae9c3 to
c0b314b
Compare
dk-lockdown
reviewed
Jul 12, 2022
dk-lockdown
reviewed
Jul 12, 2022
dk-lockdown
reviewed
Jul 12, 2022
dk-lockdown
reviewed
Jul 16, 2022
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: https://github.com/cectc/dbpack/issues/
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
jaeger trace result.
Ⅴ. Special notes for reviews