feature: support cross-database update transactions#193
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #193 +/- ##
==========================================
- Coverage 46.36% 46.16% -0.21%
==========================================
Files 77 77
Lines 8713 8751 +38
==========================================
Hits 4040 4040
- Misses 4286 4323 +37
- Partials 387 388 +1
Continue to review full report at Codecov.
|
dk-lockdown
requested review from
bohehe,
fatelei,
hzliangbin,
wybrobin,
zackzhangkai and
zhu733756
dk-lockdown
added
enhancement
Co-authored-by: hehe.bu <hehebu33@gmail.com>
fatelei
approved these changes
Jul 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: https://github.com/cectc/dbpack/issues/
Ⅰ. Describe what this PR did
If the update operation needs to be executed on multiple database shards, the distributed transaction should be coordinated to ensure the atomicity of the update operation.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews