Skip to content

feat: support show stmt#209

Merged
dk-lockdown merged 1 commit into
CECTC:devfrom
dk-lockdown:feature/show_databases
Aug 10, 2022
Merged

feat: support show stmt#209
dk-lockdown merged 1 commit into
CECTC:devfrom
dk-lockdown:feature/show_databases

Conversation

@dk-lockdown
Copy link
Copy Markdown
Collaborator

@dk-lockdown dk-lockdown commented Jul 23, 2022

ref: #186
ref: #187
ref: #188

Ⅰ. Describe what this PR did

support show databasesshow engines

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

there are integration tests

Ⅳ. Describe how to verify it

check ci result

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 23, 2022

Codecov Report

Merging #209 (26e79c5) into dev (12c94c4) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              dev     #209      +/-   ##
==========================================
- Coverage   42.82%   42.78%   -0.04%     
==========================================
  Files          82       82              
  Lines        9840     9849       +9     
==========================================
  Hits         4214     4214              
- Misses       5187     5196       +9     
  Partials      439      439              
Impacted Files Coverage Δ
pkg/executor/sharding.go 0.00% <0.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Copy Markdown
Collaborator

@bohehe bohehe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dk-lockdown dk-lockdown force-pushed the feature/show_databases branch from 5ef0fbf to 26e79c5 Compare August 9, 2022 03:47
@dk-lockdown dk-lockdown force-pushed the feature/show_databases branch 2 times, most recently from b57f07a to 506f0ef Compare August 10, 2022 10:04
@dk-lockdown dk-lockdown force-pushed the feature/show_databases branch from 506f0ef to ca48251 Compare August 10, 2022 10:11
@dk-lockdown dk-lockdown merged commit 1b4e902 into CECTC:dev Aug 10, 2022
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants