Skip to content

refactor: refact topology to support sharding db#234

Merged
dk-lockdown merged 2 commits into
CECTC:devfrom
dk-lockdown:feat/topo
Aug 15, 2022
Merged

refactor: refact topology to support sharding db#234
dk-lockdown merged 2 commits into
CECTC:devfrom
dk-lockdown:feat/topo

Conversation

@dk-lockdown
Copy link
Copy Markdown
Collaborator

ref: https://github.com/cectc/dbpack/issues/

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@dk-lockdown dk-lockdown added the enhancement New feature or request label Aug 9, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 9, 2022

Codecov Report

Merging #234 (5a09380) into dev (12c94c4) will increase coverage by 0.05%.
The diff coverage is 63.33%.

@@            Coverage Diff             @@
##              dev     #234      +/-   ##
==========================================
+ Coverage   42.82%   42.88%   +0.05%     
==========================================
  Files          82       82              
  Lines        9840     9857      +17     
==========================================
+ Hits         4214     4227      +13     
- Misses       5187     5189       +2     
- Partials      439      441       +2     
Impacted Files Coverage Δ
pkg/topo/topo.go 75.86% <57.69%> (-1.92%) ⬇️
pkg/misc/strings.go 90.24% <100.00%> (+0.50%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Copy Markdown
Collaborator

@bohehe bohehe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread pkg/topo/topo.go Outdated
Copy link
Copy Markdown
Collaborator

@bohehe bohehe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: hehe.bu <hehebu33@gmail.com>
@dk-lockdown dk-lockdown merged commit a8fe90d into CECTC:dev Aug 15, 2022
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants