Skip to content

feat: support show columns and show index in sharding mode#269

Merged
dk-lockdown merged 1 commit into
CECTC:devfrom
dk-lockdown:feat/show_table_meta
Sep 16, 2022
Merged

feat: support show columns and show index in sharding mode#269
dk-lockdown merged 1 commit into
CECTC:devfrom
dk-lockdown:feat/show_table_meta

Conversation

@dk-lockdown
Copy link
Copy Markdown
Collaborator

@dk-lockdown dk-lockdown commented Sep 8, 2022

ref: #191
ref: #192

Ⅰ. Describe what this PR did

Support show columns and show index

II. Describe how to verify it

Check integration test result
image

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #269 (554b0a9) into dev (f896fc3) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              dev     #269      +/-   ##
==========================================
- Coverage   43.03%   42.95%   -0.09%     
==========================================
  Files          84       85       +1     
  Lines       10059    10078      +19     
==========================================
  Hits         4329     4329              
- Misses       5276     5295      +19     
  Partials      454      454              
Impacted Files Coverage Δ
pkg/optimize/optimize_show_table_meta.go 0.00% <0.00%> (ø)
pkg/optimize/optimize_show_table_status.go 0.00% <0.00%> (ø)
pkg/optimize/optimizer.go 30.76% <0.00%> (-2.57%) ⬇️
pkg/plan/show_table_meta.go 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Copy Markdown
Collaborator

@bohehe bohehe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dk-lockdown dk-lockdown merged commit 2c20554 into CECTC:dev Sep 16, 2022
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants