Add Float 2d snap rounding #8797

LeoValque · 2025-03-24T07:49:24Z

Summary of Changes

Add two functions that given a range of segments, rounds their coordinates to double while preserving the topology "up to collapse". These functions differ from the actual snap rounding by rounding on double or any irregular grid instead of integer or any regular grid.

OutputContainer::iterator double_snap_rounding_2(InputIterator begin, InputIterator end, OutputContainer& outputs a range of polylines, each polyline corresponding to snapped version of an input segment.

OutputContainer::iterator compute_snapped_subcurves_2(InputIterator begin, InputIterator end, OutputContainer& outputs all the segments resulting from the snap rounding of the input.

TODO

New files are currently in package Snap rounding 2 but the copyrights of this package is not GF. Possibility: A new package? (THe feature seems to small for that) or move in Polygon_repair (owned by GF and quite link to the subject, be careful to not bring Arrangement_2 as dependancies).

Release Management

Affected package(s): Snap rounding 2 ***
Feature/Small Feature (if any):
Link to compiled documentation (obligatory for small feature) wrong link name to be changed
License and copyright ownership: GF

Snap_rounding_2/include/CGAL/Float_snap_rounding_2.h

sloriot · 2025-04-01T19:38:21Z

Also, I think the user will be interested in having a correspondence between input and output segments

Snap_rounding_2/include/CGAL/Float_snap_rounding_2.h

afabri · 2025-06-30T15:07:44Z

What is the status of this pull request ?

albert-github · 2025-11-06T14:06:19Z

Looks like there are still errors in the documentation.
From https://cgal.geometryfactory.com/CGAL/Manual_doxygen_test/CGAL-6.2-Ic-35/logs_master/Snap_rounding_2.log:

/home/cgal-testsuite/cgal_doc_build/CGAL-6.2-Ic-35/doc/Snap_rounding_2/Concepts/FloatSnapRoundingTraits_2.h:7: warning: unable to resolve reference to 'CGAL::snap_rounding_' for \ref command
/home/cgal-testsuite/cgal_doc_build/CGAL-6.2-Ic-35/doc/Snap_rounding_2/Concepts/FloatSnapRoundingTraits_2.h:149: warning: unable to resolve link to 'FloatSnapRoundingTraits_2::ConstructRoundPoint_2' for \link command
/home/cgal-testsuite/cgal_doc_build/CGAL-6.2-Ic-35/doc/Snap_rounding_2/Concepts/FloatSnapRoundingTraits_2.h:166: warning: unable to resolve link to 'FloatSnapRoundingTraits_2::SquaredRoundBound_2' for \link command
/home/cgal-testsuite/cgal_doc_build/CGAL-6.2-Ic-35/doc/Snap_rounding_2/Concepts/FloatSnapRoundingTraits_2.h:183: warning: unable to resolve link to 'FloatSnapRoundingTraits_2::ConverterToExact' for \link command
/home/cgal-testsuite/cgal_doc_build/CGAL-6.2-Ic-35/doc/Snap_rounding_2/Concepts/FloatSnapRoundingTraits_2.h:202: warning: unable to resolve link to 'FloatSnapRoundingTraits_2::ConverterToExact' for \link command

Maybe: FloatSnapRoundingTraits_2 -> FSRTraits_2

albert-github · 2025-11-06T14:18:25Z

From https://cgal.geometryfactory.com/CGAL/Manual_doxygen_test/CGAL-6.2-Ic-35/logs_master/Box_intersection_d.log (though file is changed in this PR):

/home/cgal-testsuite/cgal_doc_build/CGAL-6.2-Ic-35/doc/Box_intersection_d/Box_intersection_d.txt:174: warning: unable to resolve reference to 'Box_intersection_d/boxes_with_different_types.cpp' for \ref command

Probably something with the EXAMPLE_PATH settings

github-actions · 2025-11-06T16:31:56Z

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8797/v0/Manual/index.html

afabri · 2025-11-12T08:36:09Z

Failure in the VC2017 testsuite CGAL-6.2-Ic-39

Snap_rounding_2/test/Snap_rounding_2/test_float_snap_rounding_2.cpp

Arrangement_on_surface_2/include/CGAL/Arr_segment_traits_2.h

STL_Extension/include/CGAL/STL_Extension/internal/parameters_interface.h

Snap_rounding_2/doc/Snap_rounding_2/Concepts/FloatSnapRoundingTraits_2.h

Snap_rounding_2/include/CGAL/Float_snap_rounding_2.h

Surface_sweep_2/examples/Surface_sweep_2/plane_sweep.cpp

Snap_rounding_2/include/CGAL/Float_snap_rounding_2.h

sloriot · 2025-12-05T08:37:07Z

Snap_rounding_2/include/CGAL/Float_snap_rounding_2.h

+*   \cgalParamNEnd
+*/
+template <class InputIterator , class OutputIterator, class NamedParameters = parameters::Default_named_parameters>
+OutputIterator compute_snapped_subcurves_2(InputIterator  	 begin,


why 2 versions?

One function takes an input segment and returns a polyline of points that correspond to that segment, ensuring a clear mapping between the input and the output. The other function simply outputs a range of segments that it is easier to use.

Snap_rounding_2/doc/Snap_rounding_2/Concepts/FloatSnapRoundingTraits_2.h

sloriot · 2025-12-12T12:53:34Z

doc errors:

https://cgal.geometryfactory.com/CGAL/Manual_doxygen_test/CGAL-6.2-Ic-60/logs2/Snap_rounding_2.log
https://cgal.geometryfactory.com/CGAL/Manual_doxygen_test/CGAL-6.2-Ic-60/logs_master/Snap_rounding_2.log

albert-github · 2025-12-16T10:42:45Z

From the overnight documentation build (https://cgal.geometryfactory.com/CGAL/Manual_doxygen_test/CGAL-6.2-Ic-63/logs_master/Snap_rounding_2.log):

/home/cgal-testsuite/cgal_doc_build/CGAL-6.2-Ic-63/include/CGAL/Float_snap_rounding_2.h:797: warning: unable to resolve reference to 'bgl_namedparameters' for \ref command
/home/cgal-testsuite/cgal_doc_build/CGAL-6.2-Ic-63/include/CGAL/Float_snap_rounding_2.h:800: warning: unable to resolve reference to 'bgl_namedparameters' for \ref command
/home/cgal-testsuite/cgal_doc_build/CGAL-6.2-Ic-63/include/CGAL/Float_snap_rounding_2.h:814: warning: expected <tr> or </table> tag but found token TK_COMMAND_AT instead!
/home/cgal-testsuite/cgal_doc_build/CGAL-6.2-Ic-63/include/CGAL/Float_snap_rounding_2.h:815: warning: unexpected end of comment while inside <dl> block
/home/cgal-testsuite/cgal_doc_build/CGAL-6.2-Ic-63/include/CGAL/Float_snap_rounding_2.h:680: warning: unable to resolve reference to 'bgl_namedparameters' for \ref command
/home/cgal-testsuite/cgal_doc_build/CGAL-6.2-Ic-63/include/CGAL/Float_snap_rounding_2.h:683: warning: unable to resolve reference to 'bgl_namedparameters' for \ref command
/home/cgal-testsuite/cgal_doc_build/CGAL-6.2-Ic-63/include/CGAL/Float_snap_rounding_2.h:703: warning: expected <tr> or </table> tag but found token TK_COMMAND_AT instead!
/home/cgal-testsuite/cgal_doc_build/CGAL-6.2-Ic-63/include/CGAL/Float_snap_rounding_2.h:704: warning: unexpected end of comment while inside <dl> block
/home/cgal-testsuite/cgal_doc_build/CGAL-6.2-Ic-63/include/CGAL/Float_snap_rounding_2.h:546: warning: unable to resolve reference to 'bgl_namedparameters' for \ref command
/home/cgal-testsuite/cgal_doc_build/CGAL-6.2-Ic-63/include/CGAL/Float_snap_rounding_2.h:549: warning: unable to resolve reference to 'bgl_namedparameters' for \ref command
/home/cgal-testsuite/cgal_doc_build/CGAL-6.2-Ic-63/include/CGAL/Float_snap_rounding_2.h:563: warning: expected <tr> or </table> tag but found token TK_EOF instead!
/home/cgal-testsuite/cgal_doc_build/CGAL-6.2-Ic-63/include/CGAL/Float_snap_rounding_2.h:563: warning: unexpected end of comment while inside <dl> block
/home/cgal-testsuite/cgal_doc_build/CGAL-6.2-Ic-63/include/CGAL/Float_snap_rounding_2.h:421: warning: unable to resolve reference to 'bgl_namedparameters' for \ref command
/home/cgal-testsuite/cgal_doc_build/CGAL-6.2-Ic-63/include/CGAL/Float_snap_rounding_2.h:424: warning: unable to resolve reference to 'bgl_namedparameters' for \ref command
/home/cgal-testsuite/cgal_doc_build/CGAL-6.2-Ic-63/include/CGAL/Float_snap_rounding_2.h:438: warning: expected <tr> or </table> tag but found token TK_EOF instead!
/home/cgal-testsuite/cgal_doc_build/CGAL-6.2-Ic-63/include/CGAL/Float_snap_rounding_2.h:438: warning: unexpected end of comment while inside <dl> block

warning: unable to resolve reference to 'bgl_namedparameters' for \ref command
missing dependency in documentation dependencies file
warning: expected <tr> or </table> tag but found token TK_EOF instead!
missing command \cgalNamedParamsEnd
warning: unexpected end of comment while inside <dl> block
collateral damage due to previous error

MaelRL added Enhancement Pkg::Snap_rounding_2 labels Mar 24, 2025

MaelRL added this to the 6.2-beta milestone Mar 24, 2025

sloriot requested changes Apr 1, 2025

View reviewed changes

afabri reviewed Apr 7, 2025

View reviewed changes

Snap_rounding_2/include/CGAL/Float_snap_rounding_2.h Show resolved Hide resolved

sloriot changed the base branch from master to main September 18, 2025 15:19

sloriot added Under Testing and removed Under Testing labels Oct 20, 2025

MaelRL added Not yet approved The feature or pull-request has not yet been approved. Small feature labels Oct 30, 2025

This comment was marked as outdated.

Sign in to view

sloriot added the Under Testing label Nov 5, 2025

This comment was marked as outdated.

Sign in to view

afabri reviewed Nov 20, 2025

View reviewed changes

Snap_rounding_2/test/Snap_rounding_2/test_float_snap_rounding_2.cpp Show resolved Hide resolved

afabri reviewed Nov 20, 2025

View reviewed changes

Snap_rounding_2/test/Snap_rounding_2/test_float_snap_rounding_2.cpp Show resolved Hide resolved

LeoValque mentioned this pull request Nov 24, 2025

Do curves intersect does not work with EPICK #9151

Open

Creation of float_snap_rounding_2.h and its example .cpp

173ae7b

LeoValque and others added 17 commits December 1, 2025 10:11

cleaning Float_snap_rounding.h

92fd905

More cleaning of Float_snap_rounding_2

58caea2

Enhance documentation of FLoat snap rounding 2

ec7b77b

change reference

fc83e54

Fix error of the testsuite

6918848

Fix documentation

ec71e01

Fix documentation

cb5893a

Add a test with differents Kernels

92807e9

Fix the example

803ef35

Some additional test

19c832b

clean test

422338c

Solved invalid iterator after erased with MSVC

e63869e

Fix dangling reference warning of the testsuite

b0388e4

workaround issue with MSVC2017

4a2ebc5

push the constexpr back

e7fe2e7

Use Simple_cartesian instead of Cartesian

4c5b917

Forget that do_curves_intersect does not work with EPICK

eec0ae3

sloriot force-pushed the Float_2D_snap-GF branch from b6c1f9a to eec0ae3 Compare December 1, 2025 09:46

sloriot reviewed Dec 1, 2025

View reviewed changes

Arrangement_on_surface_2/include/CGAL/Arr_segment_traits_2.h Outdated Show resolved Hide resolved

sloriot reviewed Dec 5, 2025

View reviewed changes

LeoValque added 2 commits December 10, 2025 08:51

First path on the review

14aba48

Apply suggestions of the review

acec954

sloriot force-pushed the Float_2D_snap-GF branch from dfde505 to acec954 Compare December 10, 2025 07:58

Fix error on MSVC

b80ce2f

LeoValque and others added 3 commits December 12, 2025 15:02

Fix doc

161507b

add license

a8bbddf

tabs

a8b60b5

sloriot removed the Under Testing label Dec 17, 2025

Add Float 2d snap rounding #8797

Are you sure you want to change the base?

Add Float 2d snap rounding #8797

Uh oh!

Conversation

LeoValque commented Mar 24, 2025 • edited by sloriot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of Changes

TODO

Release Management

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sloriot commented Apr 1, 2025

Uh oh!

Uh oh!

afabri commented Jun 30, 2025

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

albert-github commented Nov 6, 2025

Uh oh!

albert-github commented Nov 6, 2025

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

github-actions bot commented Nov 6, 2025

Uh oh!

afabri commented Nov 12, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sloriot Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

LeoValque Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sloriot commented Dec 12, 2025

Uh oh!

albert-github commented Dec 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

LeoValque commented Mar 24, 2025 •

edited by sloriot

Loading