[DPC-4823] Call consentdb directly from aggregation #2757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7dc1e98.
ashley-weaver
requested review from
a team,
MEspositoE14s and
jdettmannnava
MEspositoE14s
approved these changes
Sep 19, 2025
Comment on lines
+45
to
+49
| <sqlCheck expectedResult="YES"> | ||
| SELECT is_nullable | ||
| FROM information_schema.columns | ||
| WHERE table_name = 'consent' | ||
| AND column_name = 'effective_date' |
There was a problem hiding this comment.
I'm kind of shocked there isn't a prebuilt tag to do this, but 👍
There was a problem hiding this comment.
you and me both 🙃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/DPC-4823
🛠 Changes
Moves consentdb call into dpc-aggregation.
ℹ️ Context
We will be removing dpc-consent, and this is a good first step in that process. Depends on this PR in dpc-ops.
🧪 Validation
Build and smoke test passing here.