Skip to content

Reorder upload and security middlewares #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

mdmower-csnw
Copy link

  • Move multipart middleware after security middleware so that security handlers can abort request pipeline before uploads are processed.

Fixes cdimascio#865

- Move multipart middleware after security middleware so that security
  handlers can abort request pipeline before uploads are processed.

Fixes cdimascio#865
@mdmower-csnw
Copy link
Author

Workflows were disabled when I originally opened this PR. Hence the close and reopen to trigger CI.

Copy link

@speck14 speck14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdmower Review +

@mdmower-csnw mdmower-csnw merged commit fecc989 into csnw Oct 20, 2023
@mdmower-csnw mdmower-csnw deleted the mdm-reorder-middleware branch October 20, 2023 19:01
mdmower-csnw pushed a commit that referenced this pull request May 29, 2024
* Add multiple path parameters with wildcard tests

* Change regex to support multiple params when including file path params (#1)

* Change regex to support multiple params when including URI path param
* Update regex, remove unnecessary bracket

---------

Co-authored-by: Guillermo Recalde <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

multipartMiddleware preceeds securityMiddleware so files begin uploading before security check
3 participants