Skip to content

Added step argument transformation for human readable integer expression #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 4, 2021

Conversation

thathi
Copy link
Contributor

@thathi thathi commented Feb 4, 2021

Purpose

#65 Readability

Approach

And I open the record at position 1st in the grid

TODOs

  • Automated test coverage for new code
  • Documentation updated (if required)
  • Build and tests successful

Copy link
Member

@ewingjm ewingjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @thathi. Looks good - just a few small changes needed 🙂

ewingjm
ewingjm previously approved these changes Feb 4, 2021
Copy link
Member

@ewingjm ewingjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @thathi! I'll just run the validation pipeline and we can get this merged.

@ewingjm
Copy link
Member

ewingjm commented Feb 4, 2021

/azp run Capgemini.PowerApps.SpecFlowBindings PR

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@thathi
Copy link
Contributor Author

thathi commented Feb 4, 2021

/azp run Capgemini.PowerApps.SpecFlowBindings PR

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 66 in repo Capgemini/powerapps-specflow-bindings

@ewingjm
Copy link
Member

ewingjm commented Feb 4, 2021

/azp run Capgemini.PowerApps.SpecFlowBindings PR

@thathi Don't worry - it didn't work for me either! 😄 I had to manually start it in Azure DevOps.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 4, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@ewingjm ewingjm merged commit 941bdae into Capgemini:master Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants