Skip to content

Added pending_rewards API call to Testnet 8.X branch #782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

Marcin-Radecki
Copy link
Contributor

This is a slightly modified port of #778 to Testnet 8.X brach

Runtime spec_version is 44 which might sound controversial, but we need to use the first free number that is not used. This ie because spec_version needs to identify uniquely aleph-runtime, just in case of wrongly updated runtime on Tesnet or Mainnet.

Copy link
Contributor

@kostekIV kostekIV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

controversial approve

Copy link
Contributor

@DamianStraszak DamianStraszak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about 44 -- this then changes our policy about bumping by one in our PRs, i.e., we need to jump over 44 in this case.

I guess it's fine, but could you please spread awareness somehow (writing on dev-core or something)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants