Skip to content

Allow specifying a custom text/code editor for raw JSON edit #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
CarlosNZ opened this issue Jan 24, 2025 · 0 comments · Fixed by #161
Closed

Allow specifying a custom text/code editor for raw JSON edit #157

CarlosNZ opened this issue Jan 24, 2025 · 0 comments · Fixed by #161
Assignees
@CarlosNZ
Labels
enhancement New feature or request should do

Comments

@CarlosNZ
Copy link
Owner

Suggestion

The plain text "textarea" input is okay, but it'd be nice to take advantage of more fully-featured code editors if desired. Eg: https://www.npmjs.com/package/react-ace

Suggest offering an optional prop to pass in a text editor component to handle this.
@CarlosNZ CarlosNZ added enhancement New feature or request should do labels Jan 24, 2025
@CarlosNZ CarlosNZ self-assigned this Jan 27, 2025
@CarlosNZ CarlosNZ mentioned this issue Jan 29, 2025
Merged
CarlosNZ added a commit that referenced this issue Jan 29, 2025
@CarlosNZ
#157 Custom Text Editor (#161)
9de6b37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CarlosNZ CarlosNZ

Labels
enhancement New feature or request should do
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#157 Custom Text Editor CarlosNZ/json-edit-react
1 participant
@CarlosNZ