Fixed all imports by DeborahOlaboye · Pull Request #644 · CarmineOptions/derisk-research

DeborahOlaboye · 2025-07-26T14:13:53Z

This PR fixes all import statements across the project:

Sorted imports according to project style
Converted relative imports to absolute where necessary

Closes #638

Valera56pub

You need to run:
docker-compose -f devops/dev/docker-compose.dashboard-app.yaml up --build
AND
docker-compose -f devops/dev/docker-compose.data-handler.yaml up --build
Make sure both commands build and run without errors!

Valera56pub · 2025-07-26T18:30:43Z

apps/shared/tests/test_helpers.py

-from ..helpers import add_leading_zeros, get_addresses, get_symbol
-from ..custom_types.base import TokenParameters
+from apps.shared.helpers import add_leading_zeros, get_addresses, get_symbol
+from apps.shared.custom_types.base import TokenParameters


must be:

from shared.helpers import add_leading_zeros, get_addresses, get_symbol from shared.custom_types.base import TokenParameters

Valera56pub · 2025-07-26T18:31:37Z

apps/shared/state/nostra/__init__.py

-from .alpha import NostraAlphaState
-from .mainnet import NostraMainnetState
+from nostra.alpha import NostraAlphaState
+from nostra.mainnet import NostraMainnetState


must be:

from shared.state.nostra.alpha import NostraAlphaState from shared.state.nostra.mainnet import NostraMainnetState

Valera56pub · 2025-07-26T18:32:34Z

apps/data_handler/handlers/helpers.py

 import google.cloud.storage
 import pandas
-from .order_books.constants import TOKEN_MAPPING
+from handlers.order_books.constants import TOKEN_MAPPING


must be:

from data_handler.handlers.order_books.constants import TOKEN_MAPPING

Valera56pub

Why don't you run this to check whether your code works correctly?

docker-compose -f devops/dev/docker-compose.dashboard-app.yaml up --build
AND
docker-compose -f devops/dev/docker-compose.data-handler.yaml up --build

DeborahOlaboye · 2025-07-27T08:25:52Z

Why don't you run this to check whether your code works correctly?

docker-compose -f devops/dev/docker-compose.dashboard-app.yaml up --build AND docker-compose -f devops/dev/docker-compose.data-handler.yaml up --build

Thank you for the feedback! I’ve run the following commands to verify that everything works correctly.

docker-compose -f devops/dev/docker-compose.dashboard-app.yaml up --build
docker-compose -f devops/dev/docker-compose.data-handler.yaml up --build

I really appreciate your patience throughout this process. I apologize for the back-and-forth, it wasn’t my intention to cause any extra work. Hopefully, this will be the final review. Thanks again!

Valera56pub · 2025-07-27T12:27:26Z

I’ve run the following commands to verify that everything works correctly.

Then you have seen errors like this:

DeborahOlaboye · 2025-07-28T18:34:32Z

I’ve run the following commands to verify that everything works correctly.

Then you have seen errors like this:

I have made further changes; however, it seems that the issue is dependent on issue #636 . This needs to be resolved to ensure the commands run correctly.

Attached below is the error I’m currently encountering.

Thank you!

Valera56pub · 2025-07-29T08:47:44Z

apps/dashboard_app/app/telegram_app/telegram/__main__.py

@@ -1,5 +1,5 @@

-from . import bot
+from telegram import bot


it must be:
dashboard_app.[full_path].telegram import bot

Valera56pub · 2025-07-29T08:48:21Z

apps/dashboard_app/charts/main.py



-from .constants import ChartsHeaders, CommonValues
-from .main_chart_figure import (


dashboard_app.[full_path].charts

Valera56pub · 2025-07-29T08:48:35Z

apps/dashboard_app/charts/main.py

    get_total_amount_by_field,
 )
-from .utils import (
+from charts.utils import (


dashboard_app.[full_path].utils

Valera56pub · 2025-07-29T08:48:58Z

apps/dashboard_app/charts/main_chart_figure.py

 from shared.state import State

-from .constants import CommonValues
+from charts.constants import CommonValues


dashboard_app.[full_path].constants

Valera56pub · 2025-07-29T08:49:08Z

apps/dashboard_app/charts/main_chart_figure.py

 )

-from .constants import SUPPLY_STATS_TOKEN_SYMBOLS_MAPPING
+from charts.constants import SUPPLY_STATS_TOKEN_SYMBOLS_MAPPING


dashboard_app.[full_path].constants

Valera56pub · 2025-07-29T08:49:19Z

apps/dashboard_app/helpers/protocol_stats.py

    get_supply_function_call_parameters,
 )
-from .tools import get_underlying_address
+from helpers.tools import get_underlying_address


dashboard_app.[full_path].tools

Valera56pub · 2025-07-29T08:51:36Z

I have made further changes; however, it seems that the issue is dependent on issue #636 . This needs to be resolved to ensure the commands run correctly.

That fork will be merged today, and you will be able to review this issue

DeborahOlaboye · 2025-07-29T13:03:51Z

I have made further changes; however, it seems that the issue is dependent on issue #636 . This needs to be resolved to ensure the commands run correctly.

That fork will be merged today, and you will be able to review this issue

Okay, it has now been reviewed. Thank you.

Valera56pub · 2025-07-29T13:59:07Z

Also fix all issues above

DeborahOlaboye · 2025-07-29T15:54:47Z

Also fix all issues above

I have done the checks and have no issues running the docker commands, kindly review.

Valera56pub · 2025-07-30T08:13:35Z

I have done the checks and have no issues running the docker commands, kindly review.

resolve this :
#644 (comment)
and others

DeborahOlaboye · 2025-07-30T16:31:06Z

I have done the checks and have no issues running the docker commands, kindly review.

resolve this : #644 (comment) and others

Okay, Done. Thank you.

Valera56pub

Well done. LGTM

fixed all imports

9becd75

DeborahOlaboye marked this pull request as draft July 26, 2025 17:32

Valera56pub suggested changes Jul 26, 2025

View reviewed changes

fixed imports

de8abcc

DeborahOlaboye marked this pull request as ready for review July 26, 2025 19:50

DeborahOlaboye requested a review from Valera56pub July 26, 2025 19:50

fix utils import

9eb5fe7

Valera56pub suggested changes Jul 27, 2025

View reviewed changes

fixed specific imports

0902e5e

DeborahOlaboye requested a review from Valera56pub July 27, 2025 08:26

DeborahOlaboye marked this pull request as draft July 27, 2025 17:48

resolved imports

6b81c78

DeborahOlaboye marked this pull request as ready for review July 28, 2025 18:35

Valera56pub suggested changes Jul 29, 2025

View reviewed changes

resolved merge conflict

27b8d1f

DeborahOlaboye requested a review from Valera56pub July 29, 2025 13:02

resolved all imports

045563e

Valera56pub approved these changes Jul 31, 2025

View reviewed changes

djeck1432 merged commit f8cf85c into CarmineOptions:master Jul 31, 2025
2 checks passed

djeck1432 self-requested a review July 31, 2025 08:32



		from .constants import ChartsHeaders, CommonValues
		from .main_chart_figure import (

Conversation

DeborahOlaboye commented Jul 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Valera56pub left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Valera56pub left a comment

Choose a reason for hiding this comment

Why don't you run this to check whether your code works correctly?

Uh oh!

DeborahOlaboye commented Jul 27, 2025

Why don't you run this to check whether your code works correctly?

Uh oh!

Valera56pub commented Jul 27, 2025

Uh oh!

DeborahOlaboye commented Jul 28, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Valera56pub commented Jul 29, 2025

Uh oh!

DeborahOlaboye commented Jul 29, 2025

Uh oh!

Valera56pub commented Jul 29, 2025

Uh oh!

DeborahOlaboye commented Jul 29, 2025

Uh oh!

Valera56pub commented Jul 30, 2025

Uh oh!

DeborahOlaboye commented Jul 30, 2025

Uh oh!

Valera56pub left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

DeborahOlaboye commented Jul 26, 2025 •

edited

Loading