Skip to content

CI toolset bump #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

CI toolset bump #266

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93db97b
CI toolset bump
ntfshard Jul 9, 2025
9b3f358
Update .github/workflows/build.yml
ntfshard Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/scripts/compile.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
echo off

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to shut down output it should be @echo off
imho explicit is better

set PLATFORM=%1
set ARCH=%2
set BUILDMODE=%3
Expand Down
19 changes: 8 additions & 11 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
arch: ['x86', 'x64']

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: Install 32 bit support
run: sudo apt-get install gcc-multilib g++-multilib

Expand All @@ -32,13 +32,12 @@ jobs:
buildmode: ['release']

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: Build
run: .github/scripts/compile.sh ${{ matrix.platform }} ${{ matrix.arch }} ${{ matrix.buildmode }}
- name: Run
run: .github/scripts/run_tests.sh


build-windows:
runs-on: 'windows-latest'

Expand All @@ -47,14 +46,12 @@ jobs:
platform: ['windows']
arch: ['x86', 'x64']
buildmode: ['debug', 'release']
toolset: ['14.3','14.2','14.1']

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- uses: ilammy/msvc-dev-cmd@v1
with:
arch: ${{ matrix.arch }}
toolset: ${{ matrix.toolset }}
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/ilammy/msvc-dev-cmd?tab=readme-ov-file#inputs

- name: Build
run: .github/scripts/compile.bat ${{ matrix.platform }} ${{ matrix.arch }} ${{ matrix.buildmode }}
- name: Run
Expand All @@ -71,17 +68,17 @@ jobs:
ndkversion: [21]

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4

- name: Set up JDK 1.11
- name: Set up JDK 17
uses: actions/setup-java@v3
with:
distribution: 'zulu' # See 'Supported distributions' for available options
java-version: '11'
distribution: 'temurin' # See 'Supported distributions' for available options
java-version: '17'

# Sets ANDROID_HOME + ANDROID_NDK_ROOT
- name: Setup Android SDK
uses: android-actions/setup-android@v2
uses: android-actions/setup-android@v3

- name: Build
run: .github/scripts/compile.sh ${{ matrix.platform }} ${{ matrix.arch }} ${{ matrix.buildmode }}
Expand Down
Loading