[ENG-467] Upgrade dependencies #654

jamescdavis · 2019-04-26T21:19:43Z

Purpose

Upgrade most dependencies to latest stable versions in preparation for Ember version upgrade.

Summary of Changes

upgrade all dependencies with latest patch versions
upgrade all dependencies with latest minor versions except:
- ember-source
- ember-data
- ember-cli
- ember-cli-meta-tags (some change in 5.1.0 causes things to break in weird ways)
upgrade most other dependencies to latest major version, making any code changes needed
not upgraded:
- ember-bootstrap (too many things break in 2.x)
- ember-cli-addon-docs (custom fork)
- ember-cli-addon-docs-typedoc (custom fork)
- ember-cli-babel (7.x causes builds to fail)
- ember-cli-clipboard (pinned due to some incompatibility)
- ember-cli-template-lint
- ember-cli-typescript
- ember-content-placeholders (custom fork)
- ember-decorators
- ember-engines (custom fork)
- ember-font-awesome
- ember-metrics (custom fork)
- ember-parachute (custom fork)
- keen-analysis
- keen-dataviz
- keen-tracking
- stylelint-config-sass-guidelines
- tsutils

Side Effects

hopefully not

Feature Flags

n/a

QA Notes

This does not require any specific QA.

Ticket

https://openscience.atlassian.net/browse/ENG-467

Reviewer Checklist

coveralls · 2019-04-26T21:39:59Z

Pull Request Test Coverage Report for Build 2934

37 of 40 (92.5%) changed or added relevant lines in 14 files are covered.
10 unchanged lines in 6 files lost coverage.
Overall coverage increased (+0.4%) to 71.97%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
app/guid-user/quickfiles/controller.ts	0	1	0.0%
app/models/osf-model.ts	0	1	0.0%
lib/osf-components/addon/components/editable-field/tags-manager/component.ts	2	3	66.67%

Files with Coverage Reduction	New Missed Lines	%
lib/osf-components/addon/components/validated-input/checkboxes/component.ts	1	60.0%
lib/osf-components/addon/components/validated-input/power-select/component.ts	1	80.43%
lib/osf-components/addon/components/validated-input/date/component.ts	1	77.42%
lib/osf-components/addon/components/editable-field/institutions-manager/component.ts	1	87.67%
lib/osf-components/addon/components/validated-input/recaptcha/component.ts	2	74.42%
lib/osf-components/addon/components/editable-field/tags-manager/component.ts	4	79.31%

Totals
Change from base Build 2933:	0.4%
Covered Lines:	6146
Relevant Lines:	7694

💛 - Coveralls

jamescdavis

Here's some comments explaining why individual changes were necessary.

jamescdavis · 2019-04-29T15:28:00Z

lib/app-components/addon/components/subject-picker/component.ts

-    }),
+            column.set('subjects', taxonomies ? taxonomies.toArray() : []);
+        },
+    ),


I reformatted this, but the only change is adding types for parents and tier.

jamescdavis · 2019-04-29T15:31:00Z

config/environment.js

@@ -291,6 +291,9 @@ module.exports = function(environment) {
        mirageScenarios: MIRAGE_SCENARIOS,

        defaultProvider: 'osf',
+        pageTitle: {
+            prepend: false,
+        },


[email protected] changes the default to true: ember-cli/ember-page-title@4.0.5...5.0.0

jamescdavis · 2019-04-29T16:30:39Z

app/models/osf-model.ts

@@ -94,7 +94,7 @@ export default class OsfModel extends Model {

        // HACK: ember-data discards/ignores the link if an object on the belongsTo side
        // came first. In that case, grab the link where we expect it from OSF's API
-        const url = reference.link() || getRelatedHref(this.relationshipLinks[relationshipName]);
+        const url = reference.link() || getRelatedHref(this.relationshipLinks[relationshipName as string]);


This is due to the types changes to RelationshipsFor. RelationshipsFor includes the possibility of attribute keys of type symbol, which type Relationships does not accept. We previously restricted to string keys:

ember-osf-web/types/ember-osf-web/ember-data.d.ts

Line 5 in c9539c1

export type RelationshipsFor<Model, T extends keyof Model = keyof Model> = T extends string ? T : never;

but this now breaks this.hasMany() above due to stricter typing in ember-data.

jamescdavis · 2019-04-29T16:31:37Z

app/home/styles.scss

@@ -156,7 +156,7 @@
    background: url('/assets/images/home/Ana_transparent_gradient.png') no-repeat center bottom;
    background-size: contain;
    position: relative;
-    margin: -80px 0 -65px 0;
+    margin: -80px 0 -65px;


https://stylelint.io/user-guide/rules/shorthand-property-no-redundant-values/

jamescdavis · 2019-04-29T16:33:01Z

app/guid-user/quickfiles/controller.ts

@@ -44,7 +44,7 @@ export default class UserQuickfiles extends Controller {
        }
    });

-    flash = task(function *(item: File, message: string, type = 'success', duration = 2000) {
+    flash = task(function *(item: File, message: string, type: string = 'success', duration: number = 2000) {


There appears to be a change (possibly a regression) in TypeScript 3.4 that prevents it form inferring the type from default arguments in some cases (turn on the noImplicitAny option). Here's the same with TypeScript 3.3 (as of this writing typescript-play.js.org was still on 3.3. Note: noImplicitAny is on by default in this playground).

jamescdavis · 2019-04-29T19:10:20Z

tests/unit/metric-adapters/keen-test.ts

@@ -17,7 +21,7 @@ module('Unit | Metrics Adapter | keen ', hooks => {
        const trackPublic = this.stub(adapter, 'trackPublicEvent');
        const trackPrivate = this.stub(adapter, 'trackPrivateEvent');

-        this.stub(adapter, 'getCurrentNode').resolves({ public: true });
+        this.stub(adapter, 'getCurrentNode').resolves(make('node', { public: true }) as Node);


Stricter Sinon types need a Node here, so we make one.

jamescdavis · 2019-04-29T19:13:11Z

tests/unit/models/osf-model-test.ts

@@ -216,7 +217,8 @@ module('Unit | Model | osf-model', hooks => {
        const pageSize = 100;

        for (const total of totals) {
-            let allResults = Array.from({ length: total }).map(() => ({}));
+            const id = 1;
+            let allResults = Array.from({ length: total }).map(() => ({ id, modelName: 'foo' }));


Sinon stub return type needs to match sparseHasMany.

jamescdavis · 2019-04-29T19:21:28Z

types/ember-osf-web/ember-data.d.ts

-    export type RelationshipsFor<Model, T extends keyof Model = keyof Model> = T extends string ? T : never;
+    export type ModelKeys<Model extends DS.Model> = Exclude<keyof Model, keyof DS.Model>;
+    export type AttributesFor<Model extends DS.Model> = ModelKeys<Model>;
+    export type RelationshipsFor<Model extends DS.Model> = ModelKeys<Model>;


Match what's in the ember-data types. (these are duplicated here only because they're not exported from ember-data)

jamescdavis · 2019-04-29T19:23:03Z

tests/unit/validators/password-strength-test.ts

@@ -17,7 +17,7 @@ module('Unit | Validator | password-strength', hooks => {
            const validator = this.owner.lookup('validator:password-strength');
            const options = { min: i };
            const builtOptions = validator.buildOptions(options);
-            const message = await validator.validate(minima[i], builtOptions.copy());
+            const message = await validator.validate(minima[i], Object.assign({}, builtOptions));


.copy() is removed in newer versions of ember-validator.

jamescdavis · 2019-04-29T19:27:44Z

tests/unit/adapters/osf-adapter-test.ts

-        });
+        const user = FactoryGuy.make('user');
+        user.set('links', { self: url });
+


ember-data-factory-guy 3.2.1 makes some breaking changes to links.

…ypes

remove 30s test timout override

jamescdavis · 2019-05-06T17:04:37Z

mirage/factories/node.ts

@@ -76,7 +76,7 @@ export default Factory.extend<MirageNode & NodeTraits>({

    withContributors: trait<MirageNode>({
        afterCreate(node, server) {
-            const contributorCount = faker.random.number({ min: 1, max: 25 });
+            const contributorCount = faker.random.number({ min: 1, max: 5 });


25 make mirage too slow.

They should respond properly to changes in user permissions, even though it will rarely matter outside of tests.

jamescdavis force-pushed the upgrade_dependencies branch 4 times, most recently from ac7dc06 to b3e816c Compare April 29, 2019 19:20

jamescdavis commented Apr 29, 2019

View reviewed changes

jamescdavis added 24 commits May 3, 2019 15:51

chore: upgrade all dependencies with latest patch versions

e31861c

types: update for more restrictive RelationshipsFor/AttributesFor

eb0cfa5

chore: upgrade all dependencies with latest minor versions

53a88fd

tests: remove duplicate osf-adapter test

5800b2a

tests: update ember-data-factory-guy usage for 3.7

4b478bd

types: update for improved typechecking

5a807d8

chore: upgrade to TypeScript 3.4.5

5afc529

chore: upgrade dependencies to stable or latest rc

0ceff0c

types: s/Array<unknown>/unknown[]/

b9341ae

tests: reduce dashboard project count to 21

e329e83

tests: stub head-tags for collections route unit tests

bf373e4

chore: downgrade ember-cli-meta-tags to 5.0.0

ebbdf23

chore: upgrade to @ember/jquery 0.6.0

2c43581

chore: upgrade to @ember/[email protected]

d3337e6

upgrade to @ember/[email protected]

2470e58

chore: upgrade to @types/[email protected]

224d82c

chore upgrade to @types/[email protected]

f5098c9

chore: upgrade to @types/[email protected]

d1d3724

types: update keen adapter test for stricter sinon types

83f2e76

types: update registries-navbar integration test for stricter sinon t…

3704879

…ypes

chore: upgrade to [email protected]

26e101d

chore: upgrade to [email protected]

2c97bb1

chore: upgrade to [email protected]

4525ef4

chore: upgrade to [email protected]

42d98d4

jamescdavis added 17 commits May 3, 2019 15:58

chore: upgrade to [email protected]

d21538f

chore: upgrade to [email protected]

cfadec4

tests: use Object.assign instead of .copy()

5369ffd

chore: upgrade to [email protected]

349d89a

chore: upgrade to [email protected]

a8232c9

chore: upgrade to [email protected]

928f121

chore: upgrade to [email protected]

af06f54

chore: increase testem browser disconnect timeout

c3e2cd6

chore: upgrade to [email protected]

055bc8d

chore: upgrade to [email protected]

b8fade5

chore: upgrade to [email protected]

8ae6d9c

chore: upgrade to [email protected]

7043990

chore: upgrade to [email protected]

76605b5

chore: upgrade to [email protected]

e7f903c

chore: upgrade to [email protected]

25f1735

chore: upgrade to [email protected]

aa8ffbe

chore: upgrade to latest minor versions

1580171

jamescdavis force-pushed the upgrade_dependencies branch from b3e816c to 1580171 Compare May 3, 2019 20:02

tests: change withContributors node trait to max out at 5

e489f7e

remove 30s test timout override

jamescdavis commented May 6, 2019

View reviewed changes

jamescdavis requested a review from aaxelb May 6, 2019 17:07

jamescdavis changed the title ~~Upgrade dependencies~~ [ENG-275] Upgrade dependencies May 7, 2019

jamescdavis changed the title ~~[ENG-275] Upgrade dependencies~~ [ENG-467] Upgrade dependencies May 7, 2019

aaxelb and others added 2 commits May 20, 2019 11:58

Merge branch 'develop' into upgrade_dependencies

3559ee0

fix: make managers more test-friendly

bc5be2f

They should respond properly to changes in user permissions, even though it will rarely matter outside of tests.

aaxelb approved these changes May 20, 2019

View reviewed changes

Merge branch 'develop' into upgrade_dependencies

b070c86

jamescdavis merged commit 0bd7503 into CenterForOpenScience:develop May 20, 2019

jamescdavis deleted the upgrade_dependencies branch May 20, 2019 20:02

jamescdavis added this to the 19.5.0 milestone May 30, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ENG-467] Upgrade dependencies #654

[ENG-467] Upgrade dependencies #654

jamescdavis commented Apr 26, 2019 •

edited

Loading

coveralls commented Apr 26, 2019 •

edited

Loading

jamescdavis left a comment

jamescdavis Apr 29, 2019

jamescdavis Apr 29, 2019

jamescdavis Apr 29, 2019

jamescdavis Apr 29, 2019 •

edited

Loading

jamescdavis Apr 29, 2019 •

edited

Loading

jamescdavis Apr 29, 2019

jamescdavis Apr 29, 2019

jamescdavis Apr 29, 2019

jamescdavis Apr 29, 2019

jamescdavis Apr 29, 2019 •

edited

Loading

jamescdavis May 6, 2019

[ENG-467] Upgrade dependencies #654

[ENG-467] Upgrade dependencies #654

Conversation

jamescdavis commented Apr 26, 2019 • edited Loading

Purpose

Summary of Changes

Side Effects

Feature Flags

QA Notes

Ticket

Reviewer Checklist

coveralls commented Apr 26, 2019 • edited Loading

Pull Request Test Coverage Report for Build 2934

💛 - Coveralls

jamescdavis left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jamescdavis Apr 29, 2019 • edited Loading

Choose a reason for hiding this comment

jamescdavis Apr 29, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jamescdavis Apr 29, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jamescdavis commented Apr 26, 2019 •

edited

Loading

coveralls commented Apr 26, 2019 •

edited

Loading

jamescdavis Apr 29, 2019 •

edited

Loading

jamescdavis Apr 29, 2019 •

edited

Loading

jamescdavis Apr 29, 2019 •

edited

Loading