Merged
Conversation
exceptions: * ember-data-factory-guy - 3.8.1+ requires pretender 3.0+, which conficts with ember-cli-mirage < 1.0 * typescript - 3.5+ "fixes" an issue with property initialization that prevents use of defaultTo
brianjgeiger
approved these changes
May 31, 2019
Contributor
brianjgeiger
left a comment
brianjgeiger
left a comment
There was a problem hiding this comment.
This looks good if it passes tests and Percy.
Pull Request Test Coverage Report for Build 2975
💛 - Coveralls |
jamescdavis
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Upgrade dependencies that don't require any code or configuration change.
Summary of Changes
ember-data-factory-guy- 3.8.1+ requires pretender 3.0+, which conflicts with ember-cli-mirage < 1.0 (and ember-cli-mirage 1.0 requires code change due to unbundling of faker)typescript- 3.5+ "fixes" an issue with property initialization that prevents use of defaultTo (start reading at Added error for class properties used within their own declaration microsoft/TypeScript#29395 (comment) if you want to know more)ember-a11y-testing@1.0.0stylelint-config-sass-guidelines@6.0.0ember-sinon@4.0.0Side Effects
Hope not!
Feature Flags
n/a
QA Notes
n/a
Ticket
n/a
Reviewer Checklist
CHANGELOG.md