Skip to content

[ENG-467] Upgrade dependencies #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 31, 2019
Merged

[ENG-467] Upgrade dependencies #679

merged 5 commits into from
May 31, 2019

Conversation

jamescdavis
Copy link
Member

Purpose

Upgrade dependencies that don't require any code or configuration change.

Summary of Changes

Side Effects

Hope not!

Feature Flags

n/a

QA Notes

n/a

Ticket

n/a

Reviewer Checklist

  • meets requirements
  • easy to understand
  • DRY
  • testable and includes test(s)
  • changes described in CHANGELOG.md

exceptions:
* ember-data-factory-guy - 3.8.1+ requires pretender 3.0+, which conficts with ember-cli-mirage < 1.0
* typescript - 3.5+ "fixes" an issue with property initialization that prevents use of defaultTo
@jamescdavis jamescdavis mentioned this pull request May 31, 2019
5 tasks
Copy link
Contributor

@brianjgeiger brianjgeiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good if it passes tests and Percy.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2975

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.009%

Totals Coverage Status
Change from base Build 2964: 0.0%
Covered Lines: 6176
Relevant Lines: 7726

💛 - Coveralls

@jamescdavis jamescdavis merged commit 1f9e053 into develop May 31, 2019
@jamescdavis jamescdavis deleted the upgrade_dependencies branch May 31, 2019 15:38
@jamescdavis jamescdavis added this to the 19.5.0 milestone May 31, 2019
@jamescdavis jamescdavis changed the title Upgrade dependencies [no ticket] Upgrade dependencies Jun 7, 2019
@jamescdavis jamescdavis changed the title [no ticket] Upgrade dependencies [ENG-467] Upgrade dependencies Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants