Skip to content

Conversation

@j9liu
Copy link
Contributor

@j9liu j9liu commented Jan 13, 2026

Sometimes getRootTileAvailableEvent will resolve with a nullptr root tile if there are errors while loading (e.g., attempting to load a tileset from an invalid URL). This is desired behavior, even if the name is slightly misleading for the situation.

The loadMetadata function will now account for this possibility to avoid a nullptr deference error.

@j9liu j9liu requested a review from timoore January 13, 2026 20:11
@j9liu j9liu added this to the February 2026 Release milestone Jan 13, 2026
@j9liu
Copy link
Contributor Author

j9liu commented Jan 15, 2026

Wait I'm pretty confused. I noticed that the promise is supposed to reject if something goes wrong loading the root tile:

thiz->_rootTileAvailablePromise.reject(

Wouldn't that also make the corresponding future reject? So why wouldn't the getRootTileAvailableEvent reject as well?

@j9liu j9liu marked this pull request as draft January 15, 2026 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants