Skip to content

Changed repo structure #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2019
Merged

Changed repo structure #1

merged 1 commit into from
Jan 7, 2019

Conversation

Mikerah
Copy link
Contributor

@Mikerah Mikerah commented Jan 7, 2019

The directory structure is outdated. I have changed it to make it much simpler and easier to add to in the future. Initially, I will be coding up all gossip sub functionality in index.js. If needed, we can later refactor into more files and changes the repo structure.

@Mikerah Mikerah requested a review from GregTheGreek January 7, 2019 13:34
@GregTheGreek
Copy link
Member

Do we want to do it in typescript for consistency?

@Mikerah
Copy link
Contributor Author

Mikerah commented Jan 7, 2019

I would say no because the eventually go I had in mind was to integrate this into js-libp2p. From what I know about libp2p's roadmap for this year, they are focusing on building new communities around other implementations of libp2p (it doesn't seem to include Typescript).

It does seem like there are others that want to have some form of Typescript compatibility. For example, this issue was added to their backlog but has no activity.

I would suggest that we initially do a JS one as a placeholder because this does need to be worked on. Later one, we can pick up where that issue left off and contribute even more to libp2p.

Thoughts?

@GregTheGreek
Copy link
Member

I would say no because the eventually go I had in mind was to integrate this into js-libp2p.

Wth that being said, i agree.

I would suggest that we initially do a JS one as a placeholder because this does need to be worked on. Later one, we can pick up where that issue left off and contribute even more to libp2p.

This is probably the best approach.

@GregTheGreek GregTheGreek merged commit 6fd060e into master Jan 7, 2019
@GregTheGreek GregTheGreek deleted the directory_structure branch January 7, 2019 16:02
tysonclugg added a commit to tysonclugg/js-libp2p-gossipsub that referenced this pull request Apr 17, 2025
@tysonclugg
fix(deps)!: Upgrade node/npm engine spec
d6e2d9a 
The engine spec applied here matches the minimum requirements of all transient dependencies (in `package-lock.json`). The engine requirement is changed from `npm` version to `node` version to better match with the engine spec discovered as outlined in the install attempts below (nobody seems to depend on npm versions, only node version).

With `engine-strict=true` in `.npmrc`, I attempted to install with old versions of node/npm, until successfully installed and tested.

Minimum spec install attempt ChainSafe#1:
```
$ nvm install v18.1.0
v18.1.0 is already installed.
Now using node v18.1.0 (npm v8.8.0)
$ npm install
npm ERR! code EBADENGINE
npm ERR! engine Unsupported engine
npm ERR! engine Not compatible with your version of node/npm: @semantic-release/[email protected]
npm ERR! notsup Not compatible with your version of node/npm: @semantic-release/[email protected]
npm ERR! notsup Required: {"node":">=20.8.1"}
npm ERR! notsup Actual:   {"npm":"8.8.0","node":"v18.1.0"}
```

Minimum spec install attempt ChainSafe#2:
```
$ nvm install v20.8.1
v20.8.1 is already installed.
Now using node v20.8.1 (npm v10.1.0)
$ npm install
npm ERR! code EBADENGINE
npm ERR! engine Unsupported engine
npm ERR! engine Not compatible with your version of node/npm: [email protected]
npm ERR! notsup Not compatible with your version of node/npm: [email protected]
npm ERR! notsup Required: {"node":"^18.18.0 || ^20.9.0 || >=21.1.0"}
npm ERR! notsup Actual:   {"npm":"10.1.0","node":"v20.8.1"}
```

Minimum spec install attempt ChainSafe#3:
```
$ nvm install v20.9.0
v20.9.0 is already installed.
Now using node v20.9.0 (npm v10.1.0)
$ npm install
npm WARN deprecated @humanwhocodes/[email protected]: Use @eslint/config-array instead
npm WARN deprecated [email protected]: Rimraf versions prior to v4 are no longer supported
npm WARN deprecated [email protected]: Rimraf versions prior to v4 are no longer supported
npm WARN deprecated [email protected]: Glob versions prior to v9 are no longer supported
npm WARN deprecated [email protected]: Glob versions prior to v9 are no longer supported
npm WARN deprecated [email protected]: Glob versions prior to v9 are no longer supported

> @chainsafe/[email protected] prepare
> npm run build

> @chainsafe/[email protected] build
> aegir build

[10:23:50] tsc [started]
[10:23:52] tsc [completed]
[10:23:52] esbuild [started]
[10:23:52] esbuild [completed]

added 219 packages, removed 312 packages, changed 607 packages, and audited 1896 packages in 14s

363 packages are looking for funding
  run `npm fund` for details

17 vulnerabilities (16 moderate, 1 high)

To address issues that do not require attention, run:
  npm audit fix

To address all issues possible (including breaking changes), run:
  npm audit fix --force

Some issues need review, and may require choosing
a different dependency.

Run `npm audit` for details.
```

BREAKING CHANGE: Requires Node v20.9.0 or newer
@tysonclugg tysonclugg mentioned this pull request Apr 17, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GregTheGreek GregTheGreek GregTheGreek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mikerah @GregTheGreek