Skip to content

fix: remove yarn.lock #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 3, 2021
Merged

fix: remove yarn.lock #159

merged 2 commits into from
Sep 3, 2021

Conversation

vasco-santos
Copy link
Collaborator

@vasco-santos vasco-santos commented Sep 3, 2021

This PR removes yarn.lock as it seems accidentally added, it was also ignored for avoid future similar accidents

@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2021

Codecov Report

Merging #159 (10e5dfe) into master (16d2c42) will not change coverage.
The diff coverage is n/a.

❗ Current head 10e5dfe differs from pull request most recent head b804758. Consider uploading reports for the commit b804758 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #159   +/-   ##
=======================================
  Coverage   76.58%   76.58%           
=======================================
  Files           2        2           
  Lines        1905     1905           
  Branches      140      140           
=======================================
  Hits         1459     1459           
  Misses        446      446           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16d2c42...b804758. Read the comment docs.

@vasco-santos
Copy link
Collaborator Author

My confusion, we do not have a package-lock here, we just ignore package-lock, but not yarn lock. Closing for now

@vasco-santos vasco-santos reopened this Sep 3, 2021
@dapplion dapplion merged commit 751ea73 into master Sep 3, 2021
@dapplion dapplion deleted the fix/remove-yarn branch September 3, 2021 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants