Skip to content

feat: implement zoom lock hotkey #6307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
pajlada wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat: implement zoom lock hotkey #6307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/controllers/hotkeys/ActionNames.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,6 +368,21 @@ inline const std::map<HotkeyCategory, ActionDefinitionMap> actionNames{
.argumentsPromptHover = "Should the tabs be enabled, disabled, "
"toggled, or live-only.",
}},
{"lockZoom",
ActionDefinition{
.displayName = "Lock zoom",
.argumentDescription = "[lock, unlock, toggle. default: toggle]",
.minCountArguments = 0,
.maxCountArguments = 1,
.possibleArguments{
{"Toggle", {}},
{"Lock zoom", {"lock"}},
{"Unlock zoom", {"unlock"}},
},
.argumentsPrompt = "New value:",
.argumentsPromptHover =
"Should the zoom be locked, unlocked, or toggled.",
}},
}},
};

Expand Down
30 changes: 30 additions & 0 deletions src/widgets/Window.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -694,6 +694,36 @@ void Window::addShortcuts()
.arg(arg);
}

return "";
}},
{"lockZoom",
[this](std::vector<QString> arguments) -> QString {
Copy link
Contributor

@github-actions github-actions bot Jun 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: lambda capture 'this' is not used [clang-diagnostic-unused-lambda-capture]

Suggested change
[this](std::vector<QString> arguments) -> QString {
[](std::vector<QString> arguments) -> QString {

QString arg = arguments.empty() ? "toggle" : arguments.front();

if (arg == "lock")
{
qInfo() << "XXX: LOCK ZOOM";
// TODO: Implement zoom locking
}
else if (arg == "unlock")
{
qInfo() << "XXX: UNLOCK ZOOM";
// TODO: Implement zoom unlocking
}
else if (arg == "toggle")
{
qInfo() << "XXX: TOGGLE ZOOM LOCK";
// TODO: Implement zoom lock toggling
}
else
{
qCWarning(chatterinoHotkeys)
<< "Invalid argument for lockZoom hotkey: " << arg;
return QString(
R"(Invalid argument for lockZoom hotkey: %1. Use "lock", "unlock", or "toggle".)")
.arg(arg);
}

return "";
}},
};
Expand Down
Loading