Refactor DebugCount by Mm2PL · Pull Request #6753 · Chatterino/chatterino2

Mm2PL · 2026-01-19T17:00:50Z

Switching to enums gives us a nice way to implement a base template that increments and decrements the DebugCount on (de)construction.

~~This fixes issues with Lua HTTP objects showing negative amounts, I don't believe we had an issue for that.~~ I undid the AutoDebugCount changes.

github-actions

clang-tidy made some suggestions

github-actions · 2026-01-20T14:07:59Z

-    DebugCount::set("last image gc: expired", numExpired);
-    DebugCount::set("last image gc: eligible", eligible);
-    DebugCount::set("last image gc: left after gc", this->allImages_.size());
+    DebugCount::set(DebugObject::LastImageGcExpired, numExpired);


warning: narrowing conversion from 'size_t' (aka 'unsigned long') to signed type 'int64_t' (aka 'long') is implementation-defined [bugprone-narrowing-conversions]

DebugCount::set(DebugObject::LastImageGcExpired, numExpired); ^

github-actions · 2026-01-20T14:08:00Z

-    DebugCount::set("last image gc: eligible", eligible);
-    DebugCount::set("last image gc: left after gc", this->allImages_.size());
+    DebugCount::set(DebugObject::LastImageGcExpired, numExpired);
+    DebugCount::set(DebugObject::LastImageGcEligible, eligible);


warning: narrowing conversion from 'size_t' (aka 'unsigned long') to signed type 'int64_t' (aka 'long') is implementation-defined [bugprone-narrowing-conversions]

DebugCount::set(DebugObject::LastImageGcEligible, eligible); ^

github-actions · 2026-01-20T14:08:00Z

-    DebugCount::set("last image gc: left after gc", this->allImages_.size());
+    DebugCount::set(DebugObject::LastImageGcExpired, numExpired);
+    DebugCount::set(DebugObject::LastImageGcEligible, eligible);
+    DebugCount::set(DebugObject::LastImageGcLeft, this->allImages_.size());


warning: narrowing conversion from 'size_type' (aka 'unsigned long') to signed type 'int64_t' (aka 'long') is implementation-defined [bugprone-narrowing-conversions]

DebugCount::set(DebugObject::LastImageGcLeft, this->allImages_.size()); ^

github-actions · 2026-01-20T14:08:00Z

+
+namespace chatterino {
+
+void DebugCount::set(DebugObject target, const int64_t &amount)


warning: chatterino::DebugCount::set: Pass small and trivially-copyable type by value (const int64_t & amount) [clazy-function-args-by-value]

Suggested change

void DebugCount::set(DebugObject target, const int64_t &amount)

void DebugCount::set(DebugObject target, int64_t amount)

src/util/DebugCount.hpp:60:

- static void set(DebugObject target, const int64_t &amount); + static void set(DebugObject target, int64_t amount);

github-actions · 2026-01-20T14:08:00Z

 }

-void DebugCount::decrease(const QString &name, const int64_t &amount)
+void DebugCount::decrease(DebugObject target, const int64_t &amount)


warning: chatterino::DebugCount::decrease: Pass small and trivially-copyable type by value (const int64_t & amount) [clazy-function-args-by-value]

Suggested change

void DebugCount::decrease(DebugObject target, const int64_t &amount)

void DebugCount::decrease(DebugObject target, int64_t amount)

src/util/DebugCount.hpp:68:

- static void decrease(DebugObject target, const int64_t &amount); + static void decrease(DebugObject target, int64_t amount);

github-actions · 2026-01-20T14:08:00Z

+
 namespace chatterino {

+enum class DebugObject : size_t {


warning: enum 'DebugObject' uses a larger base type ('size_t' (aka 'unsigned long'), size: 8 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size]

enum class DebugObject : size_t { ^

github-actions · 2026-01-20T14:08:00Z

+        case chatterino::DebugObject::MessageThread:
+        case chatterino::DebugObject::Message:
+        default:
+            return default_tag;


warning: Using copy-ctor but class magic_enum::customize::customize_t has a trivial copy-ctor but non trivial assign operator [clazy-rule-of-two-soft]

return default_tag; ^

pajlada

Feel free to apply the clang-tidy suggestions about const& params on the set calls

pajlada · 2026-01-24T11:53:31Z


-    static void set(const QString &name, const int64_t &amount);
+template <DebugObject target>
+class AutoDebugCount


Could we hold off on the AutoDebugCount implementation for a follow-up PR?

pajlada · 2026-01-24T11:54:15Z


 // NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
-UniqueAccess<std::map<QString, Count>> COUNTS;
+UniqueAccess<std::array<Count, static_cast<size_t>(DebugObject::Count)>> COUNTS;


Can make use of magic_enum's enum_size function here, which means we don't have to keep Count

pajlada · 2026-01-24T11:57:43Z

 };

 }  // namespace chatterino
+template <>


new line

Suggested change

template <>

template <>

Mm2PL · 2026-01-24T14:41:48Z

magic_enum didn't really like me when I tried that and produced megabytes of error messages. I CBA to debug why that pile of templates dislikes me today. W dniu 24.01.2026 o 13:00, pajlada pisze:

…

Can make use of magic_enum's enum_size function here, which means we don't have to keep `Count`

That comment isn't needed anymore, we can't leak memory here anymore

Nerixyz · 2026-01-28T08:11:38Z

+    static void increase(DebugObject target, int64_t amount);
+    static void increase(DebugObject target)


The amount could default to 1, then you won't need an additional overload. Same for the decrease method.

…gcount

Mm2PL force-pushed the chore/refactor-debugcount branch from 066383c to 10cceb5 Compare January 19, 2026 17:36

Mm2PL requested a review from pajlada January 20, 2026 01:08

Nerixyz reviewed Jan 20, 2026

View reviewed changes

Comment thread src/util/DebugCount.cpp

github-actions Bot reviewed Jan 20, 2026

View reviewed changes

pajlada requested changes Jan 24, 2026

View reviewed changes

Mm2PL added 6 commits January 27, 2026 22:24

Refactor DebugCount

b4bccaf

Update all usages of DebugCount to use enum or automation

0147770

cleanup

976dbbc

That comment isn't needed anymore, we can't leak memory here anymore

changelog

d1e1ca4

Fix tests

56ef7a8

Remove 'configure', hardcode that data instead

65eb043

Mm2PL force-pushed the chore/refactor-debugcount branch from 68dceef to 65eb043 Compare January 27, 2026 21:25

Mm2PL added 3 commits January 27, 2026 23:04

Get rid of AutoDebugCount

1c990db

reformat

19f50bf

Get rid of useless refs

70a678d

Nerixyz reviewed Jan 28, 2026

View reviewed changes

pajlada approved these changes Jan 28, 2026

View reviewed changes

pajlada added 2 commits January 28, 2026 09:49

Merge remote-tracking branch 'origin/master' into chore/refactor-debu…

b781bd6

…gcount

b

fc622fd

pajlada enabled auto-merge (squash) January 28, 2026 10:14

pajlada merged commit 60ecf1a into master Jan 28, 2026
19 checks passed

pajlada deleted the chore/refactor-debugcount branch January 28, 2026 10:37


		namespace chatterino {

		void DebugCount::set(DebugObject target, const int64_t &amount)

	void DebugCount::decrease(DebugObject target, const int64_t &amount)
	void DebugCount::decrease(DebugObject target, int64_t amount)

		static void increase(DebugObject target, int64_t amount);
		static void increase(DebugObject target)

Uh oh!

Conversation

Mm2PL commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions Bot Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

pajlada left a comment

Choose a reason for hiding this comment

Uh oh!

pajlada Jan 24, 2026

Choose a reason for hiding this comment

Uh oh!

pajlada Jan 24, 2026

Choose a reason for hiding this comment

Uh oh!

pajlada Jan 24, 2026

Choose a reason for hiding this comment

Uh oh!

Mm2PL commented Jan 24, 2026 via email

Uh oh!

Nerixyz Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Mm2PL commented Jan 19, 2026 •

edited

Loading