feat(plugins): Add images and image sets#6792
Open
Nerixyz wants to merge 2 commits intoChatterino:masterfrom
Open
feat(plugins): Add images and image sets#6792Nerixyz wants to merge 2 commits intoChatterino:masterfrom
Nerixyz wants to merge 2 commits intoChatterino:masterfrom
Conversation
Mm2PL
added
the
hold for release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When adding message construction and introspection, I left out images. This PR intends to add them.
Images are special, because plugin authors can specify a URL that Chatterino will load if the image is shown. While the plugin can't see the response, it still causes Chatterino to issue a request, so creating images will require the network permission.
Other than that, images and image sets are mostly straight forward. You can query them and on sets, you can change the images. Note that sets are value types, so getting an image set in Lua will always refer to a copy, not a reference.
When querying the empty image, Chatterino would try to access
frames_which is not set there. I wonder why this never caused any problems before (guess we filter empty images before layout?). But I added checks in the accessors.