Add an icon to show that settings have tooltips#6837
Open
Conversation
Contributor
|
Some comments:
|
Hopefully this looks better than rendering to a QPixmap. We should already have qt svgwidgets because we bring in qt svg.
Collaborator
Author
|
- Having the icon in the top left corner looks weird - I'd prefer if this was similar to your screenshot in #6833 of Factorio.
I centered it
- I'd prefer the icon to be an `i` (similar to Factorio), though we usually use the outlined icons.
I'll make an ⓘ version soon™.
- Some settings have a colon after the name. With the tooltip indicator, this looks off.
It does. Putting the icon after the action element (eg combo box) looks
even more wrong to me
- The tooltip on the indicator should have a smaller delay (maybe even no delay at all?).
This is a Qt limitation I believe. Unless we want to make our own
tooltip machinery. We cannot change that, I'll look into it but if it
turns out too complex I will not be doing it in this PR.
- On high DPI screens, the icon looks blurry.
That's apparently because of the 'width' and 'height' attributes on the
root elem. Hopefully using a QSvgWidget will help with that.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6833. This explores the Factorio-esque icon idea.
Icon is made by me