chore(filters): Remove unused Type::Map#6839
Open
Nerixyz wants to merge 1 commit intoChatterino:masterfrom
Open
chore(filters): Remove unused Type::Map#6839Nerixyz wants to merge 1 commit intoChatterino:masterfrom
Type::Map#6839Nerixyz wants to merge 1 commit intoChatterino:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In filters, we could never instantiate a
Map(neither users nor the context map), so the type was essentially unused. This PR removes it.We shouldn't need a map type for filters and at least until now, there isn't a feature request for this. If filters need to perform more complex operations, I suggest we allow plugins to create filters.