-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Fixes to test_long_sync_untrusted_break #20327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
emlowe
wants to merge
5
commits into
main
Choose a base branch
from
EL.test_long_sync_untrusted_break
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+21
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmineKhaldi
previously approved these changes
Dec 9, 2025
Contributor
AmineKhaldi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done.
arvidn
previously approved these changes
Dec 13, 2025
Contributor
|
nice catch. I take it you grepped for other instances of |
Contributor
Author
|
I did search for other instances and I didn't find any |
Pull Request Test Coverage Report for Build 20248433891Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test didn't work properly as the
time_out_assertswere notawaited (but ratherasserted - I'm assuming a typo - but this was not checked by linting)Once changed to proper await one of the checks didn't work at all, so I adjusted the code somewhat to rely on parsing LOG messages
Discovered during Python 3.14 testing which has better checks for missing awaits
Note
Stabilizes
test_long_sync_untrusted_breakby awaiting timeouts, simulating untrusted sync viawait_until_closed, and verifying trusted disconnect and untrusted connection closure through log assertions.chia/_tests/wallet/sync/test_wallet_sync.py:test_long_sync_untrusted_break:peer.wait_until_closed()in mockedregister_for_ph_updates.patch_request_handlerwithcaplog.at_level(logging.INFO); assertstart_clientsuccess and capture untrusted connection.assert time_out_assert(...)toawait time_out_assert(...); awaitsynced_to_trustedandonly_trusted_peerchecks.sync_canceledflag and related checks.Written by Cursor Bugbot for commit ee7b9da. This will update automatically on new commits. Configure here.