Picture in Picture#7445
Open
djblu2003dk-tech wants to merge 31 commits into
Open
Conversation
Chocobozzz
reviewed
Feb 24, 2026
| token.destroy() | ||
| .catch(err => logger.error('Cannot destroy token when revoking token.', { err })) | ||
| try { | ||
| await token.destroy() |
| # Your S3 provider must support virtual hosting of buckets as PeerTube doesn't support path style requests | ||
| endpoint: '' # 's3.amazonaws.com' or 's3.fr-par.scw.cloud' for example | ||
| # If your S3 provider does not support virtual host style requests, enable path style requests | ||
| force_path_style: false |
Owner
There was a problem hiding this comment.
Is there a reason you moved these lines?
Chocobozzz
reviewed
Feb 24, 2026
|
|
||
| this.player.contextMenu(this.getContextMenuOptions()) | ||
| if (this.isInIframe()) { | ||
| // Disable custom and native context menus in embeds. |
Owner
There was a problem hiding this comment.
From your other comment (https://github.com/Chocobozzz/PeerTube/pull/7396/changes#r2809262612), it seems you can remove this
Use it from lucide
We don't have enough space below
Chocobozzz
reviewed
Feb 24, 2026
| this.controlText(isActive ? 'Exit picture-in-picture' : 'Picture-in-picture') | ||
| } | ||
|
|
||
| private buildPopoutUrl (embedUrl: string) { |
Chocobozzz
reviewed
Feb 24, 2026
| } | ||
| } | ||
|
|
||
| private getPopupPlacement () { |
Chocobozzz
reviewed
Feb 24, 2026
| margin-right: auto; | ||
| } | ||
|
|
||
| // Always show PiP button in embed, even for small fixed-size iframes. |
Owner
There was a problem hiding this comment.
I don't think it's a good idea, because it can break control bar on very small screens and it displays the icon on non supported web browsers
Owner
|
Thank you, I added some commits to fix conflicts and use another pip icon. |
Owner
|
Can you rebase/merge develop now DVR is merged? |
Contributor
Author
|
Yes, I'll work on this later this month. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changed the client and embedded player to include a Picture in Picture icon that allows for the player to pop out.
Has this been tested?