Skip to content

Conversation

@samuelhwilliams
Copy link

@samuelhwilliams samuelhwilliams commented Oct 28, 2025

Description

Adds a new option that allows results to be hidden from the dropdown when searching, if those results have already been selected. This is through a new configuration option searchRenderSelectedChoices, which closely follows the behaviour of renderSelectedChoices. It defaults to be backwards compatible.

Have put this up quite provisionally, happy to take any feedback or change requests (for example if you just want to reuse the existing setting rather than add a new one).

Fixes #1313
Fixes #1353

Screenshots (if appropriate)

Types of changes

  • Chore (tooling change or documentation change)
  • Refactor (non-breaking change which maintains existing functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the code style of this project.
  • I have added new tests for the bug I fixed/the new feature I added.
  • I have modified existing tests for the bug I fixed/the new feature I added.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@Xon Xon self-requested a review October 30, 2025 01:26
@Xon Xon added the feature Pull request that adds new functionality label Oct 30, 2025
@Xon
Copy link
Collaborator

Xon commented Oct 30, 2025

@samuelhwilliams I plan to merge #1357 first, but it looks like your change has some stray changes in the built assets. It may be easier to just revert changes to those files and then force push

@Xon
Copy link
Collaborator

Xon commented Oct 30, 2025

This does introduce a behavior change with the default of auto instead of false

@samuelhwilliams samuelhwilliams force-pushed the search-render-selected-choices branch from dca370a to a855e4c Compare October 30, 2025 07:26
@samuelhwilliams
Copy link
Author

Hi @Xon - I've removed all of the changes in public/assets - sorry, wasn't sure if you'd want those committed directly or not.

@samuelhwilliams samuelhwilliams force-pushed the search-render-selected-choices branch 2 times, most recently from 8732855 to b40c7fc Compare October 30, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Pull request that adds new functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do not show already selected items in filter search Hide Search Result when Choice is already selected

2 participants