Fix for issue #199 [BUG] vPC pair destroy/deletion fails #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akabhask
force-pushed
the
fix_for_vpc_pair_delete_failing
branch
from
1d9f3fa to
a28ef5e
Compare
akabhask
force-pushed
the
fix_for_vpc_pair_delete_failing
branch
3 times, most recently
from
21cb421 to
283d357
Compare
mdmohan
reviewed
Jun 16, 2025
| tflog.Error(ctx, "RscDeleteVpcPair: Failed to get vPC Pair after delete") | ||
| dg.AddError("Failed to get vPC Pair after delete", fmt.Sprintf("Error %v", err)) | ||
| if err != nil && err.Error() != ErrVpcPairNotFound { | ||
| tflog.Error(ctx, "RscDeleteVpcPair: Failed to get vPC Pair data after delete") |
There was a problem hiding this comment.
This error is not clear - err not "Not Found" - what can it be?
Say Deletion failed - give the error details
There was a problem hiding this comment.
Actually confusing condition.
Pls break it down:
error() == Not_Found => Good return ok may be
else { Error in delete}
akabhask
force-pushed
the
fix_for_vpc_pair_delete_failing
branch
4 times, most recently
from
e440763 to
df7266c
Compare
akabhask
force-pushed
the
fix_for_vpc_pair_delete_failing
branch
from
df7266c to
7a86c5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Vpc pair get is not part of a single fabric; it is across fabrics. If we delete the only vpc pair in one fabric, the get command would still return vpc pair info if it is present in other fabrics. During deletion, we retrieve vpc pair info to verify if the vpc pair has been deleted properly. There is a logic mismatch in this case, which is causing the delete operation to fail.
Fix:
Check if vpc pair given in config is not seen in vpc pair get after delete.
Added cases to acceptance testing.