Skip to content

TAN-7702 a11y: cookie modal issue#13802

Open
luucvanderzee wants to merge 3 commits intomasterfrom
TAN-7702-cookie-modal-issues
Open

TAN-7702 a11y: cookie modal issue#13802
luucvanderzee wants to merge 3 commits intomasterfrom
TAN-7702-cookie-modal-issues

Conversation

@luucvanderzee
Copy link
Copy Markdown
Contributor

Changelog

Fixed

  • a11y: cookie modal content is now read out

@notion-workspace
Copy link
Copy Markdown

@luucvanderzee luucvanderzee requested a review from amirabayoumi May 6, 2026 19:46
@luucvanderzee
Copy link
Copy Markdown
Contributor Author

@amirabayoumi could you quickly test if this works ok on your machine? With screenreader on, open the application, delete the cookies (DevTools > Application tab > Cookies > Control + click and clear), and refresh to see the consent modal. If everything is ok, it should read out the text in the modal and not immediately focus on the button. Thank you :)

@amirabayoumi
Copy link
Copy Markdown
Contributor

@luucvanderzee The current auto-focus behavior on the title when the modal opens is great.
But as I understand it, it would be a better accessibility pattern if the aria-label only contains the header title, for example: “Your cookie preferences - {organization name}”.

Right now, the label also includes “Accepting cookies helps us improve this platform. Read our cookie policy.”, and then the next tab stop reads “Read our cookie policy” again as a link. This creates duplicated announcements for screen reader users.

Keeping the additional text in the modal content instead of the aria-label would allow the content to be read more naturally, section by section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants