-Wunused-variable in drivers/clk/qcom/gcc-msm8996.c

[nhukc]

After enabling -Wunused-variable I see warnings in drivers/clk/qcom/gcc-msm8996.c. The variable naming and usage seems complicated here.

drivers/clk/qcom/gcc-msm8996.c:133:32: warning: unused variable 'gcc_xo_gpll0_gpll2_gpll3_gpll0_early_div_map' [-Wunused-const-variable]
static const struct parent_map gcc_xo_gpll0_gpll2_gpll3_gpll0_early_div_map[] = {
                               ^
drivers/clk/qcom/gcc-msm8996.c:141:27: warning: unused variable 'gcc_xo_gpll0_gpll2_gpll3_gpll0_early_div' [-Wunused-const-variable]
static const char * const gcc_xo_gpll0_gpll2_gpll3_gpll0_early_div[] = {
                          ^
drivers/clk/qcom/gcc-msm8996.c:187:32: warning: unused variable 'gcc_xo_gpll0_gpll2_gpll3_gpll1_gpll4_gpll0_early_div_map' [-Wunused-const-variable]
static const struct parent_map gcc_xo_gpll0_gpll2_gpll3_gpll1_gpll4_gpll0_early_div_map[] = {
                               ^
drivers/clk/qcom/gcc-msm8996.c:197:27: warning: unused variable 'gcc_xo_gpll0_gpll2_gpll3_gpll1_gpll4_gpll0_early_div' [-Wunused-const-variable]
static const char * const gcc_xo_gpll0_gpll2_gpll3_gpll1_gpll4_gpll0_early_div[] = {

[nathanchance]

Seems like they can just be removed, they haven't been used since they were introduced.

$ git grep gcc_xo_gpll0_gpll2_gpll3_gpll0_early_div b1e010c0730ab
b1e010c0730ab:drivers/clk/qcom/gcc-msm8996.c:static const struct parent_map gcc_xo_gpll0_gpll2_gpll3_gpll0_early_div_map[] = {
b1e010c0730ab:drivers/clk/qcom/gcc-msm8996.c:static const char * const gcc_xo_gpll0_gpll2_gpll3_gpll0_early_div[] = {

$ git grep gcc_xo_gpll0_gpll2_gpll3_gpll1_gpll4_gpll0_early_div b1e010c0730ab
b1e010c0730ab:drivers/clk/qcom/gcc-msm8996.c:static const struct parent_map gcc_xo_gpll0_gpll2_gpll3_gpll1_gpll4_gpll0_early_div_map[] = {
b1e010c0730ab:drivers/clk/qcom/gcc-msm8996.c:static const char * const gcc_xo_gpll0_gpll2_gpll3_gpll1_gpll4_gpll0_early_div[] = {

I'm kind of confused by your wording of "enabled -Wunused-variable". It should be enabled after commit 0a5f417 ("kbuild: clang: disable unused variable warnings only when constant"), along with disabling -Wunused-const-variable.

[nickdesaulniers]

Looks like it hasn't been used since being introduced in b1e010c.

I'm kind of confused by your wording

@Nathan-Huckleberry is looking at removing/being more specific for -Wno-unused-value in scripts/Makefile.extrawarn.

[nickdesaulniers]

patch: https://lore.kernel.org/r/20190611211134.96159-1-nhuck@google.com/

[nickdesaulniers]

sboyd accepted this on LKML: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/commit/?h=clk-next&id=da642427bd7710ec4f4140f693f59aa8521a358clk-next

[nickdesaulniers]

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=da642427bd7710ec4f4140f693f59aa8521a358c