Add PyroTech Oven and Kiln compat #219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WaitingIdly
requested changes
Aug 11, 2024
src/main/java/com/cleanroommc/groovyscript/compat/mods/pyrotech/StoneKiln.java
Outdated
Show resolved
Hide resolved
src/main/java/com/cleanroommc/groovyscript/compat/mods/pyrotech/StoneOven.java
Outdated
Show resolved
Hide resolved
src/main/java/com/cleanroommc/groovyscript/compat/mods/pyrotech/BrickOven.java
Outdated
Show resolved
Hide resolved
src/main/java/com/cleanroommc/groovyscript/compat/mods/pyrotech/BrickOven.java
Outdated
Show resolved
Hide resolved
src/main/java/com/cleanroommc/groovyscript/compat/mods/pyrotech/BrickKiln.java
Outdated
Show resolved
Hide resolved
src/main/java/com/cleanroommc/groovyscript/compat/mods/pyrotech/BrickKiln.java
Outdated
Show resolved
Hide resolved
added 2 commits
August 11, 2024 20:34
fix recipes duplicates
WaitingIdly
requested changes
Aug 11, 2024
examples/postInit/pyrotech.groovy
Outdated
| @@ -157,13 +192,13 @@ mods.pyrotech.drying_rack.recipeBuilder() | |||
|
|
|||
| mods.pyrotech.drying_rack.add('apple_to_dirt', item('minecraft:apple'), item('minecraft:dirt'), 1200) | |||
|
|
|||
| // Kiln: | |||
| // Converts an item into a new one by burning it. Has a chance to fail. | |||
| // groovyscript.wiki.pyrotech.pit_kiln.title: | |||
There was a problem hiding this comment.
since you renamed Kiln to PitKiln, youll also need to update the lang key name. should also change the title from Kiln to Pit Kiln, to be consistent
There was a problem hiding this comment.
It breaks backward compability
There was a problem hiding this comment.
renaming Kiln to PitKiln breaks backwards compatability. changing the lang key has no influence on that.
if you want to fix that, add Kiln as an alias via modifying the init to include this: Alias.generateOfClass(PitKiln.class).andGenerate("Kiln").
There was a problem hiding this comment.
still need to rename the lang keys in the lang file, eg like
-groovyscript.wiki.pyrotech.kiln.title=Kiln
+groovyscript.wiki.pyrotech.pit_kiln.title=Pit Kiln
src/main/java/com/cleanroommc/groovyscript/compat/mods/pyrotech/Barrel.java
Outdated
Show resolved
Hide resolved
added 4 commits
August 11, 2024 21:35
Comment remove of ore('ingotIron') and clean of ore('plankWood')
WaitingIdly
reviewed
Aug 11, 2024
src/main/java/com/cleanroommc/groovyscript/compat/mods/pyrotech/BrickOven.java
Outdated
Show resolved
Hide resolved
src/main/java/com/cleanroommc/groovyscript/compat/mods/pyrotech/BrickOven.java
Outdated
Show resolved
Hide resolved
src/main/java/com/cleanroommc/groovyscript/compat/mods/pyrotech/StoneOven.java
Outdated
Show resolved
Hide resolved
examples/postInit/pyrotech.groovy
Outdated
| @@ -157,13 +192,13 @@ mods.pyrotech.drying_rack.recipeBuilder() | |||
|
|
|||
| mods.pyrotech.drying_rack.add('apple_to_dirt', item('minecraft:apple'), item('minecraft:dirt'), 1200) | |||
|
|
|||
| // Kiln: | |||
| // Converts an item into a new one by burning it. Has a chance to fail. | |||
| // groovyscript.wiki.pyrotech.pit_kiln.title: | |||
There was a problem hiding this comment.
still need to rename the lang keys in the lang file, eg like
-groovyscript.wiki.pyrotech.kiln.title=Kiln
+groovyscript.wiki.pyrotech.pit_kiln.title=Pit Kiln
brachy84
approved these changes
Aug 30, 2024
brachy84
added
the
mod compat
WaitingIdly
approved these changes
Sep 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add StoneKiln, BrickedKiln, StoneOven, BrickedOven interfaces and examples