Skip to content

add Better With Addons compat #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 15, 2025

Conversation

WaitingIdly
Copy link
Collaborator

changes in this PR:

  • add compat with Better With Addons dryingBox, fireNet, infuser, lureTree, packing, rotting, sandNet, soakingBox, spindle, tatara, transmutation, and waterNet. examples and i18n for those.
  • apply the getMaxItemInput method to all applicable.
  • add the ability to launch Better With Everything (a fork of BWA+BWM that fixes some issues), at the cost of not having packing compat. could do it the other way around?
  • create the method validateStackSize to make validating by stack size easier.
  • remove @RecipeBuilderMethodDescription from the recipeBuilder method in multiple BWM Registries. this annotation did nothing in this location, it is purely a mistake.
  • add a helper method to convert IBlockStates into ItemStacks in IngredientHelper.
  • creating compat with BWA required a few accessors and one "real" mixin to BWAJEIPlugin.

this PR also currently has a TODO in BetterWithAddons relating to determining if the mod is part of BWE or BWA standalone. this is done via Loader.instance().getIndexedModList().get("betterwithaddons").getMetadata().authorList.contains("ACGaming").
The TODO exists to determine if this is the desired way to check this.

@WaitingIdly WaitingIdly added the mod compat Relating to compatability with a mod or features of a mod label Dec 1, 2024
@brachy84 brachy84 merged commit 9c13622 into CleanroomMC:master Mar 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mod compat Relating to compatability with a mod or features of a mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants