Skip to content

Fix some IDE warnings #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Dec 12, 2024
Merged

Conversation

WaitingIdly
Copy link
Collaborator

changes in this PR:

  • make a significant number of places use a pattern variable.
  • fix accessoryType validation null check promptly throwing a NPE.
  • sort modifiers so that @NotNull and @Nullable are just before the return type instead of on the line prior.
  • add @Override annotations to methods missing them.
  • replace "".equals(String) with String#isEmpty().
  • use the canonical forms of floats (1.0f instead of 1f).
  • fix a ObjectMapper.Builder having a field with the type TextureBinder instead of TextureBinder<T> when the only way to set it is via calling the method textureBinder(TextureBinder<T>).
  • add a @NotNull annotation to the parameter of a method in the JeiPlugin.
  • suppress ClassCanBeRecord warnings, as we have decided not to use those.
  • suppress unchecked warnings for cases in which the entity class in a RecipeBuilder/removal.

basically all of these are just inspection stuff, with the exception of the fixing an NPE when validating accessoryType.

@brachy84 brachy84 merged commit 4a6cf12 into CleanroomMC:master Dec 12, 2024
@WaitingIdly WaitingIdly deleted the code-adjustment branch December 12, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants