add Default GameRules #279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brachy84
requested changes
Dec 8, 2024
src/main/java/com/cleanroommc/groovyscript/compat/vanilla/GameRule.java
Outdated
Show resolved
Hide resolved
# Conflicts: # examples/postInit/custom/vanilla.groovy # src/main/java/com/cleanroommc/groovyscript/compat/vanilla/VanillaModule.java
brachy84
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes in this PR:
gameRule.setWarnNewGameRule(false)./gs applyDefaultGameRulesto apply these in-game.WorldEvent.CreateSpawnPositionis fired - as far as i can tell, it is only fired once, when the world is created. other places that do similar things listen toFMLServerStartingEvent(applies on every load),WorldEvent.Load(applies on every load), and a particularly daring one didEntityJoinWorldEvent.WorldEvent.CreateSpawnPositionon both client and server, and it only runs if thelevel.datdoes not exist (something which tripped me up on the server for a bit due to always terminating the run instead of stopping the server).run/examplesfolder instead ofexampleswhengroovyscript.use_examples_folderis set to true. bug only affects us.