Skip to content

Document Vanilla Registries #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 11, 2025

Conversation

WaitingIdly
Copy link
Collaborator

changes in this PR:

  • add documentation for vanilla registries (crafting, furnace, oreDict, player, rarity, command, gameRule).
    • add documentation for ForgeRegistryWrapper, which affects atum, aether legacy, pyrotech, and industrial foregoing docs.
    • loot, content, and inWorldCrafting are not documented in this way.
  • remove postInit/custom/vanilla.groovy, now most content is in postInit/minecraft.groovy, and the event related code is in postInit/custom/events.groovy.
  • add vanilla as an alias to the minecraft container.
  • change how the furnace recipe builder works - it now uses the lists the parent AbstractRecipeBuilder has for item i/o instead of making its own fields.
  • change the name of setDefaultGameRules to applyDefaultGameRules.
  • make Player use methods to set field values and make them private.
  • make default gamerules only apply to the overworld (applying to any other dimensions should have no effect).

@WaitingIdly WaitingIdly added the documentation Improvements or additions to documentation label Apr 10, 2025
@@ -61,7 +61,7 @@ public GSCommand() {
addSubcommand(new InfoSelfCommand());

addSubcommand(new SimpleCommand("applyDefaultGameRules", (server, sender, args) -> {
VanillaModule.gameRule.setDefaultGameRules(Objects.requireNonNull(server.getServer()).getEntityWorld().getGameRules());
VanillaModule.gameRule.applyDefaultGameRules(Objects.requireNonNull(server.getServer()).getWorld(0).getGameRules());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whats this change

@WaitingIdly WaitingIdly force-pushed the vanilla-documentation branch from 175a5b9 to 2724758 Compare May 6, 2025 06:42
@brachy84 brachy84 merged commit f19ec87 into CleanroomMC:master May 11, 2025
@WaitingIdly WaitingIdly deleted the vanilla-documentation branch May 12, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants