Chore/real time logging order (#261)#266
Merged
Merged
Conversation
The current ROS logging is buffered. I.e. `openmower logs` show logs as buffered blocks but not in real-time as they occur. This PR changes the buffering to only 1 line so that log entries get shown when they occur. I tested with OMOSv2, but did not tested with OMOSv1. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> * **Bug Fixes** * Improved real-time log display in Docker containers for better visibility during application execution. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Contributor
WalkthroughBoth Docker entrypoint scripts now source version information earlier and enable unbuffered I/O logging via ROSCONSOLE_STDOUT_LINE_BUFFERED and PYTHONUNBUFFERED environment variables. The legacy script consolidates duplicate sourcing. No functional logic changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current ROS logging is buffered. I.e.
openmower logsshow logs as buffered blocks but not in real-time as they occur.This PR changes the buffering to only 1 line so that log entries get shown when they occur.
I tested with OMOSv2, but did not tested with OMOSv1.
Summary by CodeRabbit