Skip to content

update Go version matrix and add a step for go mod tidy#5

Merged
cyrilou242 merged 1 commit into
ClickHouse:mainfrom
alexandear-org:chore/go-mod-tidy
Apr 17, 2026
Merged

update Go version matrix and add a step for go mod tidy#5
cyrilou242 merged 1 commit into
ClickHouse:mainfrom
alexandear-org:chore/go-mod-tidy

Conversation

@alexandear

Copy link
Copy Markdown
Contributor
  • Run go mod tidy to go.sum
  • Add go mod tidy step to CI
  • Use stable and oldstable aliases instead of Go version. stable currently refers to Go 1.26, oldstable - 1.25.

@alexandear alexandear requested a review from cyrilou242 as a code owner April 16, 2026 12:24
Copilot AI review requested due to automatic review settings April 16, 2026 12:24
@CLAassistant

CLAassistant commented Apr 16, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates CI and module metadata to keep dependency files tidy and to track Go versions via stable/oldstable aliases rather than pinning explicit versions.

Changes:

  • Updates the Go version test matrix to include stable and oldstable (while keeping 1.24).
  • Adds a CI step that runs go mod tidy and fails if it produces diffs.
  • Updates go.sum to reflect go mod tidy output (removing stale sums and adding the missing module checksum).

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
go.sum Aligns checksums with go mod tidy output (removes stale entries, adds missing sum).
.github/workflows/run-tests.yml Expands Go matrix using stable/oldstable and enforces go mod tidy cleanliness in CI.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@cyrilou242 cyrilou242 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @alexandear, thanks for your PR.

Run go mod tidy to go.sum
Add go mod tidy step to CI

Right and thanks for catching that go.mod and go.sum do not match 😶‍🌫️

@cyrilou242 cyrilou242 merged commit 8f76930 into ClickHouse:main Apr 17, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants