Reconnector will not be triggered when there is no onError parameter in the subscription processing

[Immanuel-Licht]

Hi Elad,
I found the reconnector will not be triggered when there is no OnError parameter in the subscription process .

    public IWampRealmProxy Start(Dictionary<string, Action<IDictionary<string, ISerializedValue>>> subscribers)
    {
        var disposables = new List<IDisposable>();
        Reconnector = new WampChannelReconnector(_channel, async () =>
        {
            await _channel.Open().ConfigureAwait(false);
            disposables.ForEach(d => d.Dispose());
            disposables.Clear();
            foreach (var sub in subscribers)
            {
                var disposable = _channel.RealmProxy.Services.GetSubject(sub.Key).Subscribe(x =>
                 {
                     sub.Value?.Invoke(x.ArgumentsKeywords);
                 });
                disposables.Add(disposable);
            }
        });
        Reconnector.Start();
        return _channel.RealmProxy;
    }

I have to add OnError paramter in Subscribe method for the connector to run normally.

                var disposable = _channel.RealmProxy.Services.GetSubject(sub.Key).Subscribe(x =>
                 {
                     sub.Value?.Invoke(x.ArgumentsKeywords);
                 }, e =>
                 {
                     Console.WriteLine(e.ToString());
                 });

I think the reconnector should not be affected.
And it caused another problem, the reconnection will be triggered when I actively close the channel.So I have to dispose the reconnector when the channel is closed ,to avoid duplicate subscriptions.

    public async Task<GoodbyeMessage> Close(string reason = WampErrors.CloseNormal)
    {
        Reconnector.Dispose();
        return await _channel.Close(reason, new GoodbyeDetails());
    }

Is original design so or my code wrong?
Thanks

[darkl]

If I recall correctly, specifying no OnError handler should cause your program to crash. See #193. This is the behavior of System.Reactive.

In this case, the reconnecter mechanism makes no sense as the program has crashed.

[Immanuel-Licht]

Thanks.
Subscription is normal without OnError handle, but can't reconnect.
By the way,maybe it's time to update the document.There should be some recommended code to ensure it is robust and reliable.

[darkl]

Why don't you submit a pull request to the WampSharp.net repository? Elad

…

On Thu, Aug 1, 2019, 21:25 Immanuel-Licht ***@***.***> wrote: Thanks. Subscription is normal without OnError handle, but can't reconnect. By the way,maybe it's time to update the document <https://wampsharp.net/wamp2/roles/subscriber/getting-started-with-subscriber/>.There should be some recommended code to ensure it is robust and reliable. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#300?email_source=notifications&email_token=AAIS75R27OR3K3FANREGR4LQCOEG5A5CNFSM4IINKBG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3MJ25Q#issuecomment-517512566>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAIS75RDDFPSDUHA2VK4SLDQCOEG5ANCNFSM4IINKBGQ> .

[darkl]

Ok, this commit makes the System.WebSockets connection consistent with the WebSocket4Net connection, i.e. exceptions not handled by the user (such as the one you get if you don't subscribe to OnError) make their program crash. I'll release a new version to NuGet in the next following days.

Elad

[Immanuel-Licht]

Well done,Elad.
Thanks.