Add Indexing Progress, Index Off Main Thread

[thecoolwinter]

Description

• Explicitly do all indexing work off the main thread, including gathering file URLs.
• Iteratively load files into memory for indexing, rather than loading all files in the workspace at once.
• Add a published indexing progress variable.
• Add a progress bar for indexing that takes enough time. For most small projects this will never be shown, for large projects it's a helpful indicator.

Related Issues

• No issues.

Checklist

• I read and understood the contributing guide as well as the code of conduct
• The issues this PR addresses are related to each other
• My changes generate no new warnings
• My code builds and runs on my machine
• My changes are all related to the related issue above
• I documented my code

Screenshots

option.1.final.mov

[LeoBorai]

LGTM!

[tom-ludwig]

@thecoolwinter Nice progress bar, I really like it! I saw Xcode shows indexing progress at the top tho. Ever thought about using that UI?

[thecoolwinter]

@activcoding yes! I would like to use a progress bar like that but we don't have the activity bar or any of the necessary API implemented. When that is finished this progress bar should be removed.

[tom-ludwig]

Looks good so far. I'm unsure about resetting the results at the start of a search tho; it seems a bit odd when a search takes longer than 0.2 seconds. Is there a specific reason not to replace the results once they are found?

[thecoolwinter]

Looks good so far. I'm unsure about resetting the results at the start of a search tho; it seems a bit odd when a search takes longer than 0.2 seconds. Is there a specific reason not to replace the results once they are found?

In massive workspaces I was finding search could take longer if the search query was small (like searching for //) and there were enough matches that finding each match in each file took long enough. In most searches it isn't necessary I agree.

[tom-ludwig]

Looks good now, all set for merging.