Skip to content

Added editor overscroll setting #2010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 5, 2025
Merged

Added editor overscroll setting #2010

merged 4 commits into from
Apr 5, 2025

Conversation

FastestMolasses
Copy link
Member

@FastestMolasses FastestMolasses commented Mar 31, 2025 •
edited
Loading

Description

Added the option for editor overscroll like in Xcode.

Related Issues

Closes #2011

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Screenshot 2025-03-30 at 6 29 32 PM

Xcode:
Screenshot 2025-03-30 at 6 33 10 PM

@FastestMolasses FastestMolasses self-assigned this Mar 31, 2025
@FastestMolasses FastestMolasses added the enhancement New feature or request label Mar 31, 2025
@FastestMolasses
Copy link
Member Author

Once the feature gets merged into TextView and the CodeEditSourceEditor, this PR will be ready.

@FastestMolasses FastestMolasses mentioned this pull request Mar 31, 2025
Merged
6 tasks
@FastestMolasses FastestMolasses marked this pull request as ready for review April 3, 2025 02:23
thecoolwinter
thecoolwinter approved these changes Apr 5, 2025
View reviewed changes
Copy link
Collaborator

@thecoolwinter thecoolwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

tom-ludwig
tom-ludwig approved these changes Apr 5, 2025
View reviewed changes
Copy link
Member

@tom-ludwig tom-ludwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to close this todo so quickly. Thanks!

@FastestMolasses FastestMolasses merged commit 050c3e3 into main Apr 5, 2025
2 checks passed
@FastestMolasses FastestMolasses deleted the overscroll branch April 5, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thecoolwinter thecoolwinter thecoolwinter approved these changes

@tom-ludwig tom-ludwig tom-ludwig approved these changes

@austincondiff austincondiff Awaiting requested review from austincondiff

Assignees

@FastestMolasses FastestMolasses

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨ Overscroll - Scroll past the end of the document
3 participants
@FastestMolasses @thecoolwinter @tom-ludwig