Skip to content

🐞 Broken example #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
huyphams opened this issue Apr 3, 2025 · 3 comments · Fixed by #310
Closed

🐞 Broken example #298

huyphams opened this issue Apr 3, 2025 · 3 comments · Fixed by #310
Labels
bug Something isn't working

Comments

@huyphams
Copy link

huyphams commented Apr 3, 2025

Description

I just clone the repo, build the example:

  1. The language selection does not work as it always render plaintext no matter the current selection.
  2. Trying to modify the source to render with the specific language, it flickering ref 🐞 Flickering on cursor move and text editing #293
  3. Not support dark theme, I build the app and my macOS on dark theme, I barely see the gutter because the label is white.

To Reproduce

  1. Clone the repo.
  2. Build the example.
  3. Open swift file
  4. Change language selection to swift

See the text is rendering as plaintext, no colour.

Expected Behavior

Should work as expected.

Version Information

CodeEditSourceEditor: Current main
macOS: 15.1.1
Xcode: 16.2

You can see that right after the language was chosen from the dropdown, it rollback to plaintext.

Image Image
@huyphams huyphams added the bug Something isn't working label Apr 3, 2025
@thecoolwinter
Copy link
Collaborator

thecoolwinter commented Apr 8, 2025

This should be inadvertently closed with #295. I'll check back and make sure that's the case once we merge that.

@austincondiff
Copy link
Collaborator

@thecoolwinter #295 has been merged. I know dark mode is supported. I know the source language picker works. What about the second concern?

@thecoolwinter
Copy link
Collaborator

I'll be looking into the second concern now. I left more information and a temp workaround on the related issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 🏁 Complete
Development

Successfully merging a pull request may close this issue.

3 participants